Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqForm.java:290-294: Fake ctor. According to new... #602

Closed
davvd opened this issue Feb 11, 2016 · 8 comments
Closed

RqForm.java:290-294: Fake ctor. According to new... #602

davvd opened this issue Feb 11, 2016 · 8 comments

Comments

@davvd
Copy link

davvd commented Feb 11, 2016

Puzzle 558-79259f7e in src/main/java/org/takes/rq/RqForm.java:290-294 has to be resolved: Fake ctor. According to new qulice version, constructor must contain only variables initialization and other constructor calls. Refactor code according to that rule and remove ConstructorOnlyInitializesOrCallOtherConstructors warning suppression.... The puzzle was created by Maksimenko Vladimir on 7-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 11, 2016

@xupyprmv the task is yours please proceed

@davvd davvd added this to the 1.0 milestone Feb 12, 2016
@davvd
Copy link
Author

davvd commented Feb 12, 2016

@yegor256 I set the milestone to 1.0 since there is nothing set yet

xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 13, 2016
xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 13, 2016
xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 16, 2016
xupyprmv added a commit to xupyprmv/takes that referenced this issue Feb 25, 2016
@xupyprmv
Copy link
Contributor

@davvd PR #612 was merged. Please, close this ticket.

@davvd davvd closed this as completed Feb 28, 2016
@davvd
Copy link
Author

davvd commented Feb 28, 2016

@yegor256 Closed, thanks all

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@ypshenychka please, check this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented Feb 28, 2016

@davvd Quality is good.

@ypshenychka thanks for the review and a good remark

@davvd
Copy link
Author

davvd commented Mar 1, 2016

@xupyprmv I added 10 mins to @ypshenychka (for QA review) in transaction 79079164; I just added 30 mins to your account, many thanks for your contribution (AP-6U271405GT1371402).. 372 hours and 36 mins spent here; +30 added to your rating, at the moment it is: +210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants