Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqMultipart class unreadable #651

Closed
wild-lotus opened this issue Mar 13, 2016 · 24 comments
Closed

RqMultipart class unreadable #651

wild-lotus opened this issue Mar 13, 2016 · 24 comments

Comments

@wild-lotus
Copy link

wild-lotus commented Mar 13, 2016

Class RqMultipart, apart from being quite long, is confusing and extremely hard to read and understand. It makes it really difficult to maintain.

Please refactor it so that it becomes more understandable. Split it into more classes or whatever it is needed for that purpose.


- `651-43df2f64`/#666 (by Nicolas FILOTTO)
@davvd
Copy link

davvd commented Mar 21, 2016

@yegor256 please do something about it, see par.21

@yegor256 yegor256 added the bug label Mar 21, 2016
@davvd davvd added this to the 1.0 milestone Mar 22, 2016
@davvd
Copy link

davvd commented Mar 22, 2016

@carlosgines since there is no milestone yet I set it to "1.0"

@davvd
Copy link

davvd commented Mar 22, 2016

@triberraar this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here... The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

@davvd
Copy link

davvd commented Mar 22, 2016

@carlosgines thank you for the ticket reported, I topped your account for 15 mins, transaction AP-2S985733VJ2962257

@davvd
Copy link

davvd commented Apr 6, 2016

@triberraar check this "no obligations principle".. This task is on your name for at least 15 days. If you can't close it within the next 48 hours I will have to assign someone else to it. This article should help if you're stuck

-30 to your rating, your total score is -90

@davvd
Copy link

davvd commented Apr 11, 2016

@triberraar it takes too long. Usually, we expect any task to be finished in less than a week. I'll assign someone else. Please stop working with it right now. See our no obligations principle... -60 to your rating, your total score is -270

@davvd davvd removed the @triberraar label Apr 12, 2016
@davvd
Copy link

davvd commented Apr 12, 2016

@essobedo the task is yours please proceed

@essobedo
Copy link
Contributor

@davvd waiting for #626

@davvd
Copy link

davvd commented Apr 12, 2016

@davvd waiting for #626

@essobedo agreed, we'll wait for #626

@essobedo
Copy link
Contributor

@davvd here is my PR #665 please find a reviewer.

@davvd
Copy link

davvd commented Apr 18, 2016

@davvd here is my PR #665 please find a reviewer.

@essobedo OK

@davvd
Copy link

davvd commented Apr 18, 2016

@carlosgines #626 is closed, we were waiting for it.. maybe we can continue?

@essobedo
Copy link
Contributor

@davvd I confirm that since #626 is closed, I can continue, I could even propose a PR as you can see above

@essobedo
Copy link
Contributor

@CarlosGines the PR has been merged, you can close the ticket, thx in advance

@wild-lotus
Copy link
Author

@essobedo closed, thank you.

@essobedo
Copy link
Contributor

@davvd The ticket is ready for the QA, thx in advance

@essobedo
Copy link
Contributor

@davvd a QA validation is needed here, thx

@davvd
Copy link

davvd commented Apr 22, 2016

@davvd I confirm that since #626 is closed, I can continue, I could even propose a PR as you can see above

@essobedo OK

@davvd
Copy link

davvd commented Apr 23, 2016

@elenavolokhova please, let us know what do you think about this ticket, according to our QA rules

@davvd
Copy link

davvd commented Apr 23, 2016

@carlosgines there is a puzzle in this code 651-43df2f64/#666, we'll resolve it later

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link

davvd commented Apr 24, 2016

@davvd Looks good!

@elenavolokhova many thanks

@davvd
Copy link

davvd commented Apr 24, 2016

@essobedo 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 84361996... thanks, I just added 30 mins to your account, payment 84362005, 89 hours and 12 mins spent... +30 added to your rating, current score is: +525

@davvd
Copy link

davvd commented Jun 14, 2016

@carlosgines the last puzzle 651-43df2f64/#666 originated from here solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants