Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqMtBase.java:80-83: This class is highly coupled,... #666

Closed
davvd opened this issue Apr 23, 2016 · 12 comments
Closed

RqMtBase.java:80-83: This class is highly coupled,... #666

davvd opened this issue Apr 23, 2016 · 12 comments

Comments

@davvd
Copy link

davvd commented Apr 23, 2016

Puzzle 651-43df2f64 in src/main/java/org/takes/rq/multipart/RqMtBase.java:80-83 has to be resolved: This class is highly coupled, it should be refactored in order to be able to reduce the overall coupling of this class which will allow to remove the violations ClassDataAbstractionCouplingCheck and PMD.ExcessiveImports.... The puzzle was created by Nicolas Filotto on 18-Apr-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Apr 23, 2016

@essobedo please proceed, it's yours

@davvd
Copy link
Author

davvd commented Apr 23, 2016

@yegor256 since the ticket has no milestone I set it to 1.0

@essobedo
Copy link
Contributor

@davvd here is the PR #668 please find a reviewer

@davvd
Copy link
Author

davvd commented Apr 23, 2016

@davvd here is the PR #668 please find a reviewer

@essobedo OK

@essobedo
Copy link
Contributor

essobedo commented May 2, 2016

@davvd need more time to be validated by the architect

@davvd
Copy link
Author

davvd commented May 2, 2016

@davvd need more time to be validated by the architect

@essobedo agreed, take your time

@essobedo
Copy link
Contributor

essobedo commented May 3, 2016

@davvd the PR has been merged, you can proceed

@davvd
Copy link
Author

davvd commented May 5, 2016

@yegor256 Thanks, closing it now.

@davvd davvd closed this as completed May 5, 2016
@davvd
Copy link
Author

davvd commented May 5, 2016

@ypshenychka please, review this issue for QA compliance, as per par.24

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented May 5, 2016

@davvd Quality is good.

@ypshenychka thanks!

@davvd
Copy link
Author

davvd commented May 5, 2016

@essobedo paied 10 mins to @ypshenychka for QA review (payment ID is 85728918)

30 mins was added to your account, many thanks for your contribution (payment 85728968)! The task took 268 hours and 33 mins.

+30 to your rating, your total score is +657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants