Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BkTimetable cannot be created directly #652

Closed
exper0 opened this issue Mar 16, 2016 · 5 comments
Closed

BkTimetable cannot be created directly #652

exper0 opened this issue Mar 16, 2016 · 5 comments

Comments

@exper0
Copy link
Contributor

exper0 commented Mar 16, 2016

For some reason BkTimetable is public but has package-local constructor. This lead to the situation when BkTimetable cannot be created from any package other than org.takes.http. Again, this leads to inability to create FtBasic the same way as it's done in FtCLI.
Creating FtBasic is needed to avoid using FtCLI because it would be right to decouple command line parsing and FtBasic creation. In application which use Takes may be much more command line arguments so using FtCLI leads to having two different pieces of code parsing command line.

So let's make BkTimetable constructor public to have more flexibility during construction of actual Takes based HTTP server.

@davvd
Copy link

davvd commented Mar 21, 2016

@yegor256 please pay attention to this issue (par.21)

yegor256 pushed a commit that referenced this issue Mar 21, 2016
@yegor256
Copy link
Owner

@exper0 fixed in 9bf9e7f thanks!

@yegor256
Copy link
Owner

@rultor release, tag is 0.32.7

@rultor
Copy link
Collaborator

rultor commented Mar 21, 2016

@rultor release, tag is 0.32.7

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Mar 21, 2016

@rultor release, tag is 0.32.7

@yegor256 Done! FYI, the full log is here (took me 9min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants