Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RsXSLT.java:143-145: continue removing usage StandardCharsets.UTF_8 from... #674

Closed
davvd opened this issue May 4, 2016 · 15 comments
Closed

Comments

@davvd
Copy link

davvd commented May 4, 2016

Puzzle 664-ddd2c9b3 in src/main/java/org/takes/rs/RsXSLT.java:143-145 has to be resolved: continue removing usage StandardCharsets.UTF_8 from takes code (remove usage not only from this class but also from other parts of project). Please look at #664 for more details.... The puzzle was created by Maksimenko Vladimir on 25-Apr-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented May 4, 2016

@dalifreire please go ahead with this task, it's yours

@davvd davvd added this to the 1.0 milestone May 4, 2016
@davvd
Copy link
Author

davvd commented May 4, 2016

@yegor256 I set the milestone to 1.0 since there is nothing set yet

@dalifreire
Copy link
Contributor

@davvd Thanks, I'm starting now...

@dalifreire
Copy link
Contributor

@davvd PR #675 created... please proceed.

@davvd
Copy link
Author

davvd commented May 5, 2016

@davvd Thanks, I'm starting now...

@dalifreire sure, you are welcome

@davvd
Copy link
Author

davvd commented May 5, 2016

@davvd PR #675 created... please proceed.

@dalifreire thanks

@dalifreire
Copy link
Contributor

@davvd The CR was done in #675... we are waiting for @yegor256 to confirm the merge.

@dalifreire
Copy link
Contributor

@davvd The PR #675 was merged. Please, proceed.

@davvd
Copy link
Author

davvd commented May 9, 2016

@davvd The CR was done in #675... we are waiting for @yegor256 to confirm the merge.

@dalifreire OK

@davvd
Copy link
Author

davvd commented May 9, 2016

@davvd The PR #675 was merged. Please, proceed.

@dalifreire thank you

@davvd davvd closed this as completed May 10, 2016
@davvd
Copy link
Author

davvd commented May 10, 2016

@yegor256 Thanks, closed

@davvd
Copy link
Author

davvd commented May 10, 2016

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link
Author

davvd commented May 11, 2016

@davvd Quality is good.

@ypshenychka thanks a lot :)

@davvd
Copy link
Author

davvd commented May 11, 2016

@dalifreire 10 mins was added to the account of @ypshenychka (for QA review), in transaction 86361412... Many thanks! 30 mins were added to your account in Transaction ID 86361432 (task took 121 hours and 55 mins)... +30 added to your rating, current score is: +75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants