Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of StandardCharsets.UTF_8 #664

Closed
essobedo opened this issue Apr 18, 2016 · 14 comments
Closed

Get rid of StandardCharsets.UTF_8 #664

essobedo opened this issue Apr 18, 2016 · 14 comments

Comments

@essobedo
Copy link
Contributor

essobedo commented Apr 18, 2016

There are many classes in the code base that rely on the public constant StandardCharsets.UTF_8 which is not a good solution for data duplication because:

  1. It introduces coupling between all those classes and StandardCharsets such that if the value is modified or simply removed those classes won't work properly anymore or won't even compile.
  2. it reduces the global cohesion of those classes as they have to add their own semantics to this external constant with no real meaning instead of focusing on their own task .

More details here and/or Section 2.5 of the book Elegant Objects.


- `664-ddd2c9b3`/#674 (by Dalí Freire Dias dos Santos)
@davvd
Copy link

davvd commented Apr 22, 2016

@yegor256 please do something about this issue

@yegor256 yegor256 added the bug label Apr 24, 2016
@davvd davvd added this to the 1.0 milestone Apr 25, 2016
@davvd
Copy link

davvd commented Apr 25, 2016

@essobedo I added milestone 1.0 to this issue, let me know if there has to be something else

@davvd
Copy link

davvd commented Apr 25, 2016

@xupyprmv it's yours,please go ahead

@davvd
Copy link

davvd commented Apr 25, 2016

@essobedo many thanks for the report, I topped your account for 15 mins, transaction 84402755

@xupyprmv
Copy link
Contributor

@davvd I added PR #670. Please find someone to review.

@davvd
Copy link

davvd commented Apr 26, 2016

@davvd I added PR #670. Please find someone to review.

@xupyprmv thank you!

@davvd
Copy link

davvd commented May 4, 2016

@essobedo there is a puzzle in this code 664-ddd2c9b3/#674, we'll resolve it later

@xupyprmv
Copy link
Contributor

xupyprmv commented May 5, 2016

@essobedo PR #670 was merged. Please close this ticket.

@essobedo essobedo closed this as completed May 5, 2016
@xupyprmv
Copy link
Contributor

xupyprmv commented May 5, 2016

@davvd This ticket is closed.

@davvd
Copy link

davvd commented May 6, 2016

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

@ypshenychka
Copy link

@davvd Quality is good.

@davvd
Copy link

davvd commented May 6, 2016

@davvd Quality is good.

@ypshenychka thanks a lot

@davvd
Copy link

davvd commented May 6, 2016

@xupyprmv just added 10 mins to @ypshenychka (for QA), payment ID is 85782608; Thanks for your contribution, 30 mins was added to your account, payment ID is AP-0AT68670G4324460D, 241 hours and 45 mins spent total; added +30 to your rating, now it is equal to +315

@davvd
Copy link

davvd commented Jun 20, 2016

@essobedo the last puzzle 664-ddd2c9b3/#674 originated from here solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants