Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqForm.java:69-71: Refacor this class to reduce... #687

Closed
davvd opened this issue Jun 17, 2016 · 15 comments
Closed

RqForm.java:69-71: Refacor this class to reduce... #687

davvd opened this issue Jun 17, 2016 · 15 comments

Comments

@davvd
Copy link

davvd commented Jun 17, 2016

Puzzle 667-ace435e8 in src/main/java/org/takes/rq/RqForm.java:69-71 has to be resolved: Refacor this class to reduce the data abstraction coupling in order to get rid of the checkstyle suppression of ClassDataAbstractionCouplingCheck... The puzzle was created by Dalí Freire on 6-May-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.


- ~~`687-875c0e1d`/#694~~ (by Vladimir Maximenko) - `687-65dc14c7`/#695 (by Dalí Freire Dias dos Santos)
@davvd
Copy link
Author

davvd commented Jun 17, 2016

@rui-castro please pick this up, and keep in mind these instructions. Any technical questions - ask right here; The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

@davvd davvd added this to the 1.0 milestone Jun 17, 2016
@davvd
Copy link
Author

davvd commented Jun 17, 2016

@yegor256 since the ticket has no milestone I set it to 1.0

@rui-castro
Copy link
Contributor

@davvd The PR #690 was created.

@davvd
Copy link
Author

davvd commented Jun 20, 2016

@davvd The PR #690 was created.

@rui-castro thank you!

@rui-castro
Copy link
Contributor

@davvd The PR is merged, can you close this issue?

@davvd
Copy link
Author

davvd commented Jun 30, 2016

@davvd The PR is merged, can you close this issue?

@rui-castro sure

@davvd
Copy link
Author

davvd commented Jun 30, 2016

@yegor256 these 2 puzzles were created in this ticket: 687-65dc14c7, 687-875c0e1d/#694

@davvd
Copy link
Author

davvd commented Jul 1, 2016

@yegor256 Thanks, closing it now.

@davvd davvd closed this as completed Jul 1, 2016
@davvd
Copy link
Author

davvd commented Jul 1, 2016

@elenavolokhova please, review this issue for QA compliance, as per par.24

@elenavolokhova
Copy link

@davvd Looks good!

@davvd
Copy link
Author

davvd commented Jul 2, 2016

@davvd Looks good!

@elenavolokhova thanks, got it, great to see high-quality tickets here

@davvd
Copy link
Author

davvd commented Jul 2, 2016

@rui-castro paied 10 mins to @elenavolokhova for QA review (payment ID is 91818593). Thanks for your contribution, 30 mins was added to your account, payment ID is AP-76U252629J0632925, 310 hours and 33 mins spent total. added +30 to your rating, now it is equal to +30

@rui-castro
Copy link
Contributor

@davvd thanks 😉

@davvd
Copy link
Author

davvd commented Jul 3, 2016

@davvd thanks 😉

@rui-castro you are welcome

@davvd
Copy link
Author

davvd commented Sep 6, 2016

@yegor256 the last puzzle 687-65dc14c7/#695 solved

0pdd referenced this issue Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants