#687 - Refactored RqForm into 1 interface and 3 smaller classes. #690
Conversation
|
@rui-castro Many thanks, I will find someone to review it before we merge |
|
@mkordas this pull request is for you, please review |
|
@rui-castro thanks for PR, I'll do a review tomorrow |
|
@rui-castro can you remove word |
|
|
||
| /** | ||
| * Implementations of the interface {@link org.takes.rq.RqForm}. | ||
| * |
There was a problem hiding this comment.
@rui-castro see Yegor's comment in yegor256/qulice#708 (comment)
|
@mkordas Removed closed from PR description and fixed comment formatting. |
|
@rui-castro thanks, I will continue my review soon |
| * @author Aleksey Popov (alopen@yandex.ru) | ||
| * @version $Id$ | ||
| * @since 0.9 | ||
| * @checkstyle ClassDataAbstractionCouplingCheck (500 lines) |
There was a problem hiding this comment.
@rui-castro looks like issue is not fully fixed, we need to create additional puzzle for it
There was a problem hiding this comment.
@mkordas yes, I can add a todo but I don't know how to create a puzzle.
There was a problem hiding this comment.
@rui-castro just add @todo as in other places :)
|
@mkordas I think I addressed all your comments with my last commit. |
|
@rui-castro I'll check it soon |
| } | ||
|
|
||
| /** | ||
| * RqFormBase returns always the same instances (Cache). |
|
@rui-castro Travis build has failed |
|
@rui-castro see my review above |
|
@rui-castro can you please solve conflicts here? |
|
@rui-castro I'll check it soon |
|
@rui-castro Travis build is failed, we need to fix it |
|
@rui-castro I think that description of puzzle is still too short: |
|
@rui-castro see my comment above |
|
@mkordas the build is fixed. |
|
@rui-castro I'll check it in a sec :) |
|
@rui-castro sorry for a delay, on it now |
|
@rui-castro looks good! |
|
@rultor merge |
|
@mkordas thanks 😉 |
|
@yegor256 we need your review here |
|
@rultor try to merge |
|
@ypshenychka please, review this issue for QA compliance, as per par.24 |
|
@rultor please deploy |
|
@rui-castro
Please provide a link to original ticket in PR's description. |
rui-castro
changed the title
|
@ypshenychka done |
|
@rui-castro Thank you. |
|
@davvd Quality is acceptable. |
@ypshenychka thank you, let's try to make it "good" next time |
|
@mkordas 10 mins was added to the account of @ypshenychka (for QA review), in transaction 91761879. Thank you, I have added 52 mins to your account in payment/transaction " |
Issue #687: Removed checkstyle suppression ClassDataAbstractionCouplingCheck from RqForm, but is still needed in RqFormBase.