Constructors of FkHitRefresh shouldn't throw any exceptions.

[skapral]

The issue was raised after this discussion - http://disq.us/p/1lgf1ax.

According to this post, constructors should not do any logic inside. For Takes framework, this rule is violated in several places. One of them is the class org.takes.facets.fork.FkHitRefresh, which handles with IO inside a constructor.

PS: @yegor256 please consider me as a contributor to solve this issue.

[0crat]

@yegor256 please, pay attention to this issue

[yegor256]

@skapral thanks! Please, submit a pull request, if you can.

[yegor256]

@0crat assign @skapral

[0crat]

@0crat assign @skapral (here)

@yegor256 Job gh:yegor256/takes#744 assigned to @skapral, please go ahead (policy). @skapral is not a member of this project yet, but can request to join. @skapral check your Zerocracy profile and follow the instructions.

[0crat]

@skapral this job was assigned to you 8 days ago.
It will be taken away from you after 10 days from start (this is our policy).

[0crat]

Oops! Job gh:yegor256/takes#744 is not assigned to anyone.

[0crat]

Oops! Job gh:yegor256/takes#744 is not assigned to anyone.

[0crat]

The job #744 assigned to @t-izbassar/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

[t-izbassar]

@0crat waiting for @skapral to decide what to do with his #745 PR.

[0crat]

@0crat waiting for @skapral to decide what to do with his #745 PR. (here)

@t-izbassar The impediment for #744 was registered successfully by @t-izbassar/z

[t-izbassar]

@skapral apparently, you are done with this one) #745 is merged, can you close it?)

[t-izbassar]

@skapral ping

[0crat]

@elenavolokhova/z please review this job, as in §30

[elenavolokhova]

@yegor256 This ticket violates QA rule:

Problem reporter and problem solver are two different persons.

Desision to let @skapral to deliver a solution to his own ticket led to incorrect situation here:

• actual problem solver is a bug reporter, but he is not assigned to this ticket any more and is not a member of this project.
• @skapral assigned to this project didn't actually solve an issue and shouldn't be paid.

Please, confirm that you'll try to avoid assigning problem reporter to his own issue in future.

I assume the quality of this ticket is bad. Please, let me know, if I'm wrong.

[t-izbassar]

@elenavolokhova can you inform 0crat about quality? Personally, I agree with you. I need this task to be closed by 0crat so that I can handle next one - thus you need to inform 0crat about the decision.

[elenavolokhova]

@t-izbassar Sure.

[elenavolokhova]

@0crat Quality is bad here.

[0crat]

@0crat Quality is bad here. (here)

@elenavolokhova Argument "is" doesn't match regex good|bad|acceptable

[elenavolokhova]

@0crat Quality bad

[0crat]

@0crat Quality bad (here)

@elenavolokhova Can't understand "bad", try one of these:

• assign Assign a performer to this issue
• boost Set a boost for the job
• hello Just say hello
• in Register this issue in scope (WBS)
• out Remove this issue from scope (WBS)
• quality Review a task
• resign Resign from this issue
• status Check the status of the job
• version Print current version of the bot
• waiting Register an impediment for a job

[elenavolokhova]

@0crat quality bad

[0crat]

QA review completed: +15 points just awarded to @elenavolokhova/z, total is +15

[t-izbassar]

@0crat status

[0crat]

@0crat status (here)

@t-izbassar This is what I know about this job, as in §32:

• The job #744 is not in scope
• Job footprint (restricted area)

[0pdd]

@skapral the puzzle #935 is still not solved; solved: #802.

[0pdd]

@skapral all 2 puzzles are solved here: #802, #935.