Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front.java:37-39: Document usage of Front interface in... #781

Closed
0pdd opened this issue Jan 29, 2018 · 16 comments
Closed

Front.java:37-39: Document usage of Front interface in... #781

0pdd opened this issue Jan 29, 2018 · 16 comments

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 29, 2018

The puzzle 373-b5720fa6 from #373 has to be resolved:

* @todo #373:15min Document usage of Front interface in README.md.
* Provide information about implementations and how and when
* they can be used in client's code.

The puzzle was created by Tolegen Izbassar on 26-Jan-18.

Estimate: 15 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

@yegor256/z please, pay attention to this issue

@0crat 0crat added the scope label Jan 29, 2018
@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Job #781 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

Job #781 is already in scope

@0crat
Copy link
Collaborator

0crat commented Feb 16, 2018

The job #781 assigned to @t-izbassar/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Feb 16, 2018
t-izbassar pushed a commit to t-izbassar/takes that referenced this issue Feb 17, 2018
@t-izbassar
Copy link
Contributor

@0crat waiting

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2018

@0crat waiting (here)

@t-izbassar The impediment for #781 was registered successfully by @t-izbassar/z

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 20, 2018

The puzzle 373-b5720fa6 has disappeared from the source code, that's why I closed this issue.

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2018

@elenavolokhova/z please review this job, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@elenavolokhova
Copy link

@t-izbassar According to our QA rules

Some of ticket messages must mention all pull requests where the problem was actually fixed.

Please, confirm that you will include the link to related PR directly in next tickets.

@t-izbassar
Copy link
Contributor

@elenavolokhova it's already linked by github. And commit messages that fixed an issue are indeed linked to the issue. What else is expected?

@elenavolokhova
Copy link

@t-izbassar Something like "Fixed in #803" would be great.
Github will add links to different issues and PRs, where this issue will be just mentioned. In such cases it is hard to follow all the logic and find needed PR. It will consume some time and extra effort. So having direct mention of fixing PR is stated in QA rules. I hope it sounds reasonable)

@t-izbassar
Copy link
Contributor

@elenavolokhova got it, thanks.

Please, confirm that you will include the link to related PR directly in next tickets.

Confirmed

@elenavolokhova
Copy link

@t-izbassar Thank you!

@elenavolokhova
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Feb 21, 2018

QA review completed: +15 points just awarded to @elenavolokhova/z, total is +30

@0crat
Copy link
Collaborator

0crat commented Feb 21, 2018

Order was finished, quality was "acceptable": +30 points just awarded to @t-izbassar/z, total is +345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants