-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toString() implementation for logging #88
Comments
@dmzaytsev please reformat the ticket so that it starts sound like a bug, see http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html#5.-report-when-it-is-broken |
I expect that this code
prints something like this I guess the lack toString() is the reason. This applies to all classes which will be loggable via org.takes.facets.slf4j(#28). |
@dmzaytsev this description of the problem is better than you original ticket description. But still, you should say what you need, not what we should do in order to satisfy your needs. You should say what is broken. In this particular ticket, I would say something like: "I expect each class to be able to convert itself to a loggable string, but they don't have this feature". It's up to "us", whether to give you toString() or some other mechanism. See my point? |
I'll create another ticket |
We need to implement toString() for all classes which will be loggable via org.takes.facets.slf4j(#28). Moreover for classes which used as parameters.
Maybe could be use @lombok.ToString?
The text was updated successfully, but these errors were encountered: