SLF4J logging

[yegor256]

Let's create a collection of wrappers in org.takes.facets.slf4j for our basic interface (Takes, Take, Fork, etc), which will log basic parameters of methods called.

We should use them like this:

new TsLogged(
  new TsFork(
    // my config...
  )
);

That should be enough to see everything that's going on with this takes.

[davvd]

@yegor256 got it, tag bug is here

[davvd]

@yegor256 many thanks, 15 mins added to your acc for reporting this bug, pmt ID 000-bac20427

[yegor256]

we need at lease these classes:

TsLogged
BkLogged
FtLogged
TkLogged
PsLogged

[davvd]

@dmzaytsev it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket

The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

[dmzaytsev]

@yegor256 could I use @com.jcabi.aspects.Loggable ?
It will be looks like this

public final class TsLogged implements Takes {
   private final transient Takes origin;
   public TsLogged(final Takes takes) {
       this.origin = takes;
   }

   @Override
   @Loggable
   public Take route(final Request request) throws IOException {
       return this.origin.route(request);
   }

}

[yegor256]

@dmzaytsev no, we can't add any third-party libraries here... we should work directly with SLF4J API

[dmzaytsev]

@yegor256
TsLogged for Takes
BkLogged for Back ?
FtLogged for Front ?
TkLogged for Take
PsLogged for Pass

right ?

[yegor256]

@dmzaytsev exactly

[dmzaytsev]

@yegor256 could you explain please how to make right ticket for puzzle ?
e.g. in this task I need to implement a few Loggers, I will make only one and create a puzzle for others. How to make right @todo and create a task (s) for other classes?

[yegor256]

@dmzaytsev you create what you think you can create in the available time frame and all the rest leave un-implemented and add puzzles there like this:

/**
 * @todo #28:30min/DEV This feature is not implemented yet, but has to be. Please
 *  implement it and don't forget about unit test. Bla-bla-bla...
 */

#28:30min/DEV is what is important. #28 is the ticket you're working on right now. 30min is how much time you think this implementation should take (it will become a budget of the new task). DEV is the role to be assigned to this task (always use DEV).

[dmzaytsev]

@yegor256 #89 is fixing this issue, please close if that's all here, thank you

[yegor256]

@dmzaytsev many thanks!

[davvd]

the code made here contains a puzzle 28-4e517112, which will be resolved soon

[davvd]

@elenavolokhova please, review this task for compliance with our quality rules

[elenavolokhova]

@davvd This ticket looks good! :)

[davvd]

@davvd This ticket looks good! :)

@elenavolokhova thanks for the review

[davvd]

@dmzaytsev 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 54709336. I just added 38 mins to your account, many thanks for your contribution.. 54709363 spent here. the bonus for fast delivery (age=3005). added +38 to your rating, now it is equal to +324

[davvd]

@yegor256 the last puzzle 28-4e517112/#119 solved