Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maven-compiler-plugin and fix bug on it to allow incremental compilation #976

Closed
fabriciofx opened this issue Apr 23, 2019 · 30 comments

Comments

@fabriciofx
Copy link
Contributor

Let's update maven-compiler-plugin to 3.8.0 version and fix a bug in this plugin which doesn't allow incremental compilation that increase compile and running time. To fix both we need change pom.xml to:

<plugin>
  <artifactId>maven-compiler-plugin</artifactId>
  <version>3.8.0</version>
  <configuration>
    <source>${jdk.version}</source>
    <target>${jdk.version}</target>
    <useIncrementalCompilation>false</useIncrementalCompilation>
  </configuration>
</plugin>

Please, pay attention to <version> and <useIncrementalCompilation> tag.

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

@paulodamaso/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

@fabriciofx/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@paulodamaso
Copy link
Contributor

@fabriciofx good catch let's do it

@paulodamaso
Copy link
Contributor

@0crat in

@0crat 0crat added the scope label Apr 23, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

@0crat in (here)

@paulodamaso Job #976 is now in scope, role is DEV

@fabriciofx
Copy link
Contributor Author

@paulodamaso For more details: https://stackoverflow.com/a/19653164

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

Bug was reported, see §29: +15 point(s) just awarded to @fabriciofx/z

@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

The job #976 assigned to @vzurauskas/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@vzurauskas
Copy link
Contributor

@0crat wait for #977 to be merged.

@0crat 0crat added the waiting label Apr 25, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

@0crat wait for #977 to be merged. (here)

@vzurauskas The impediment for #976 was registered successfully by @vzurauskas/z

@vzurauskas
Copy link
Contributor

@fabriciofx #977 was merged, can this issue be closed now?

@0crat 0crat removed the waiting label May 7, 2019
@0crat
Copy link
Collaborator

0crat commented May 7, 2019

The job #976 assigned to @Serranya/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@Serranya
Copy link
Contributor

Serranya commented May 7, 2019

@paulodamaso Why was asigned to me? @vzurauskas seems to be working on this.

@paulodamaso
Copy link
Contributor

@Serranya Looks like @0crat removed the impediment and re-assigned the issue. I'll return it to the original performer

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

@paulodamaso
Copy link
Contributor

@0crat assign @vzurauskas

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

@0crat assign @vzurauskas (here)

@paulodamaso The job #976 assigned to @vzurauskas/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; @vzurauskas/z is not a member of this project yet, but they can request to join, as §1 explains; there will be no monetary reward for this job

@paulodamaso
Copy link
Contributor

@vzurauskas Thanks!

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso/z

@paulodamaso
Copy link
Contributor

@Serranya actually @vzurauskas Exited the project, that's why @0crat assigned the issue to you.

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

Job was finished in 0 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

Job #976 is not in the agenda of @vzurauskas/z, can't inspect

@0crat 0crat removed the scope label May 7, 2019
@0crat
Copy link
Collaborator

0crat commented May 7, 2019

@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented May 7, 2019

The job #976 is now out of scope

@sereshqua
Copy link

@0crat status

@0crat
Copy link
Collaborator

0crat commented May 8, 2019

@0crat status (here)

@sereshqua This is what I know about this job in C3FFK3YAY, as in §32:

@sereshqua
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented May 8, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

@0crat
Copy link
Collaborator

0crat commented May 8, 2019

Order was finished, quality is "good": +40 point(s) just awarded to @vzurauskas/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants