(#1011) Replaced String.startsWith by cactoos scalar StartsWith #1034

fanifieiev · 2020-02-26T04:56:43Z

This PR is for issue #1011

0crat · 2020-02-26T08:12:03Z

This pull request #1034 is assigned to @fabriciofx /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

paulodamaso

@fanifieiev There are some comments, please take a look

paulodamaso · 2020-02-26T14:22:39Z

src/main/java/org/takes/rs/RsWithStatus.java

-            Collections.singletonList(
-                String.format("HTTP/1.1 %d %s", status, reason)
-            ),
+        return new Joined<>(


@fanifieiev PLease se above

paulodamaso · 2020-02-26T14:25:41Z

src/main/java/org/takes/rq/RqWithoutHeader.java

-                        req.head()
-                    );
-                },
+                () -> new Filtered<>(


@fanifieiev Wouldn't be possible to work only with Text here, without converting them to strings / evaluating it by value method , to use advantage of the lazy evaluating?

@paulodamaso For now Filtered accepts Func<X, Boolean>, so it is not possible to do what you ask for.
Instead the Filtered has to accept Func<X, Scalar<Boolean>>, then it will work.

I can create an issue in Cactoos project.

paulodamaso · 2020-02-26T14:26:38Z

src/main/java/org/takes/rs/RsWithoutHeader.java

-                        res.head()
-                    );
-                },
+                () -> new Filtered<>(


@fanifieiev PLease see above

@paulodamaso Please see here

paulodamaso · 2020-02-26T14:26:54Z

src/main/java/org/takes/servlet/HttpServletResponseFake.java

@@ -122,7 +124,9 @@ public void sendError(
        );
        try {
            return new Filtered<>(
-                hdr -> new Lowered(hdr).asString().startsWith(prefix),
+                hdr -> new StartsWith(


@fanifieiev Here also, please see above

@paulodamaso Please see here

paulodamaso · 2020-02-26T14:29:14Z

@0crat assign me

0crat · 2020-02-26T14:31:50Z

@0crat assign me (here)

@paulodamaso This pull request #1034 is assigned to @paulodamaso /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

0crat · 2020-02-26T14:33:37Z

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @paulodamaso /z

fanifieiev · 2020-03-02T20:20:53Z

@paulodamaso Please have a look here.
I have created an issue in Cactoos.

paulodamaso · 2020-03-03T01:50:04Z

@fanifieiev Thank you!

paulodamaso · 2020-03-03T01:50:12Z

@rultor merge

rultor · 2020-03-03T01:52:34Z

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-03-03T03:54:54Z

@rultor merge

@fanifieiev @paulodamaso Oops, I failed. You can see the full log here (spent 2hr)

  195. es_PE.UTF-8 UTF-8              444. ti_ER UTF-8
  196. es_PR ISO-8859-1               445. ti_ET UTF-8
  197. es_PR.UTF-8 UTF-8              446. tig_ER UTF-8
  198. es_PY ISO-8859-1               447. tk_TM UTF-8
  199. es_PY.UTF-8 UTF-8              448. tl_PH ISO-8859-1
  200. es_SV ISO-8859-1               449. tl_PH.UTF-8 UTF-8
  201. es_SV.UTF-8 UTF-8              450. tn_ZA UTF-8
  202. es_US ISO-8859-1               451. to_TO UTF-8
  203. es_US.UTF-8 UTF-8              452. tpi_PG UTF-8
  204. es_UY ISO-8859-1               453. tr_CY ISO-8859-9
  205. es_UY.UTF-8 UTF-8              454. tr_CY.UTF-8 UTF-8
  206. es_VE ISO-8859-1               455. tr_TR ISO-8859-9
  207. es_VE.UTF-8 UTF-8              456. tr_TR.UTF-8 UTF-8
  208. et_EE ISO-8859-1               457. ts_ZA UTF-8
  209. et_EE.ISO-8859-15 ISO-8859-15  458. tt_RU UTF-8
  210. et_EE.UTF-8 UTF-8              459. tt_RU@iqtelif UTF-8
  211. eu_ES ISO-8859-1               460. ug_CN UTF-8
  212. eu_ES.UTF-8 UTF-8              461. ug_CN@latin UTF-8
  213. eu_ES@euro ISO-8859-15         462. uk_UA KOI8-U
  214. eu_FR ISO-8859-1               463. uk_UA.UTF-8 UTF-8
  215. eu_FR.UTF-8 UTF-8              464. unm_US UTF-8
  216. eu_FR@euro ISO-8859-15         465. ur_IN UTF-8
  217. fa_IR UTF-8                    466. ur_PK UTF-8
  218. ff_SN UTF-8                    467. uz_UZ ISO-8859-1
  219. fi_FI ISO-8859-1               468. uz_UZ.UTF-8 UTF-8
  220. fi_FI.UTF-8 UTF-8              469. uz_UZ@cyrillic UTF-8
  221. fi_FI@euro ISO-8859-15         470. ve_ZA UTF-8
  222. fil_PH UTF-8                   471. vi_VN UTF-8
  223. fo_FO ISO-8859-1               472. wa_BE ISO-8859-1
  224. fo_FO.UTF-8 UTF-8              473. wa_BE.UTF-8 UTF-8
  225. fr_BE ISO-8859-1               474. wa_BE@euro ISO-8859-15
  226. fr_BE.UTF-8 UTF-8              475. wae_CH UTF-8
  227. fr_BE@euro ISO-8859-15         476. wal_ET UTF-8
  228. fr_CA ISO-8859-1               477. wo_SN UTF-8
  229. fr_CA.UTF-8 UTF-8              478. xh_ZA ISO-8859-1
  230. fr_CH ISO-8859-1               479. xh_ZA.UTF-8 UTF-8
  231. fr_CH.UTF-8 UTF-8              480. yi_US CP1255
  232. fr_FR ISO-8859-1               481. yi_US.UTF-8 UTF-8
  233. fr_FR.UTF-8 UTF-8              482. yo_NG UTF-8
  234. fr_FR@euro ISO-8859-15         483. yue_HK UTF-8
  235. fr_LU ISO-8859-1               484. yuw_PG UTF-8
  236. fr_LU.UTF-8 UTF-8              485. zh_CN GB2312
  237. fr_LU@euro ISO-8859-15         486. zh_CN.GB18030 GB18030
  238. fur_IT UTF-8                   487. zh_CN.GBK GBK
  239. fy_DE UTF-8                    488. zh_CN.UTF-8 UTF-8
  240. fy_NL UTF-8                    489. zh_HK BIG5-HKSCS
  241. ga_IE ISO-8859-1               490. zh_HK.UTF-8 UTF-8
  242. ga_IE.UTF-8 UTF-8              491. zh_SG GB2312
  243. ga_IE@euro ISO-8859-15         492. zh_SG.GBK GBK
  244. gd_GB ISO-8859-15              493. zh_SG.UTF-8 UTF-8
  245. gd_GB.UTF-8 UTF-8              494. zh_TW BIG5
  246. gez_ER UTF-8                   495. zh_TW.EUC-TW EUC-TW
  247. gez_ER@abegede UTF-8           496. zh_TW.UTF-8 UTF-8
  248. gez_ET UTF-8                   497. zu_ZA ISO-8859-1
  249. gez_ET@abegede UTF-8           498. zu_ZA.UTF-8 UTF-8

(Enter the items you want to select, separated by spaces.)

Locales to be generated: 4a294ce930eef6e17ac4d6b4efb3a904b1cbf35720707f30bca4b34b3300baaa
'pid' file is absent, something was broken

paulodamaso · 2020-03-09T17:48:16Z

@rultor merge

rultor · 2020-03-09T17:51:11Z

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

paulodamaso · 2020-03-09T17:53:59Z

@rultor stop

rultor · 2020-03-09T17:54:06Z

@rultor stop

@paulodamaso OK, I'll try to stop current task.

rultor · 2020-03-09T17:54:37Z

@rultor stop

@fanifieiev @paulodamaso Sorry, I failed to stop the previous command, however it has the following result: Oops, I failed. You can see the full log here (spent 3min)

  197. es_PR.UTF-8 UTF-8              446. tig_ER UTF-8
  198. es_PY ISO-8859-1               447. tk_TM UTF-8
  199. es_PY.UTF-8 UTF-8              448. tl_PH ISO-8859-1
  200. es_SV ISO-8859-1               449. tl_PH.UTF-8 UTF-8
  201. es_SV.UTF-8 UTF-8              450. tn_ZA UTF-8
  202. es_US ISO-8859-1               451. to_TO UTF-8
  203. es_US.UTF-8 UTF-8              452. tpi_PG UTF-8
  204. es_UY ISO-8859-1               453. tr_CY ISO-8859-9
  205. es_UY.UTF-8 UTF-8              454. tr_CY.UTF-8 UTF-8
  206. es_VE ISO-8859-1               455. tr_TR ISO-8859-9
  207. es_VE.UTF-8 UTF-8              456. tr_TR.UTF-8 UTF-8
  208. et_EE ISO-8859-1               457. ts_ZA UTF-8
  209. et_EE.ISO-8859-15 ISO-8859-15  458. tt_RU UTF-8
  210. et_EE.UTF-8 UTF-8              459. tt_RU@iqtelif UTF-8
  211. eu_ES ISO-8859-1               460. ug_CN UTF-8
  212. eu_ES.UTF-8 UTF-8              461. ug_CN@latin UTF-8
  213. eu_ES@euro ISO-8859-15         462. uk_UA KOI8-U
  214. eu_FR ISO-8859-1               463. uk_UA.UTF-8 UTF-8
  215. eu_FR.UTF-8 UTF-8              464. unm_US UTF-8
  216. eu_FR@euro ISO-8859-15         465. ur_IN UTF-8
  217. fa_IR UTF-8                    466. ur_PK UTF-8
  218. ff_SN UTF-8                    467. uz_UZ ISO-8859-1
  219. fi_FI ISO-8859-1               468. uz_UZ.UTF-8 UTF-8
  220. fi_FI.UTF-8 UTF-8              469. uz_UZ@cyrillic UTF-8
  221. fi_FI@euro ISO-8859-15         470. ve_ZA UTF-8
  222. fil_PH UTF-8                   471. vi_VN UTF-8
  223. fo_FO ISO-8859-1               472. wa_BE ISO-8859-1
  224. fo_FO.UTF-8 UTF-8              473. wa_BE.UTF-8 UTF-8
  225. fr_BE ISO-8859-1               474. wa_BE@euro ISO-8859-15
  226. fr_BE.UTF-8 UTF-8              475. wae_CH UTF-8
  227. fr_BE@euro ISO-8859-15         476. wal_ET UTF-8
  228. fr_CA ISO-8859-1               477. wo_SN UTF-8
  229. fr_CA.UTF-8 UTF-8              478. xh_ZA ISO-8859-1
  230. fr_CH ISO-8859-1               479. xh_ZA.UTF-8 UTF-8
  231. fr_CH.UTF-8 UTF-8              480. yi_US CP1255
  232. fr_FR ISO-8859-1               481. yi_US.UTF-8 UTF-8
  233. fr_FR.UTF-8 UTF-8              482. yo_NG UTF-8
  234. fr_FR@euro ISO-8859-15         483. yue_HK UTF-8
  235. fr_LU ISO-8859-1               484. yuw_PG UTF-8
  236. fr_LU.UTF-8 UTF-8              485. zh_CN GB2312
  237. fr_LU@euro ISO-8859-15         486. zh_CN.GB18030 GB18030
  238. fur_IT UTF-8                   487. zh_CN.GBK GBK
  239. fy_DE UTF-8                    488. zh_CN.UTF-8 UTF-8
  240. fy_NL UTF-8                    489. zh_HK BIG5-HKSCS
  241. ga_IE ISO-8859-1               490. zh_HK.UTF-8 UTF-8
  242. ga_IE.UTF-8 UTF-8              491. zh_SG GB2312
  243. ga_IE@euro ISO-8859-15         492. zh_SG.GBK GBK
  244. gd_GB ISO-8859-15              493. zh_SG.UTF-8 UTF-8
  245. gd_GB.UTF-8 UTF-8              494. zh_TW BIG5
  246. gez_ER UTF-8                   495. zh_TW.EUC-TW EUC-TW
  247. gez_ER@abegede UTF-8           496. zh_TW.UTF-8 UTF-8
  248. gez_ET UTF-8                   497. zu_ZA ISO-8859-1
  249. gez_ET@abegede UTF-8           498. zu_ZA.UTF-8 UTF-8

(Enter the items you want to select, separated by spaces.)

Locales to be generated: d44101943c1299b9061e54d4a917c42c1da80428066d275fdd05e1ecdfbc6a53
Error response from daemon: Cannot kill container: d44101943c1299b9061e54d4a917c42c1da80428066d275fdd05e1ecdfbc6a53: Container d44101943c1299b9061e54d4a917c42c1da80428066d275fdd05e1ecdfbc6a53 is not running
container d44101943c1299b9061e54d4a917c42c1da80428066d275fdd05e1ecdfbc6a53 is dead
Mon Mar  9 18:54:24 CET 2020

0crat · 2020-03-12T20:19:42Z

Job #1034 is not in the agenda of @paulodamaso /z, can't retrieve data and time of add

0crat · 2020-03-12T20:43:57Z

Code review was too long (15 days), architects (@paulodamaso) were penalized, see §55

fanifieiev added 2 commits February 25, 2020 23:54

(yegor256#1011) Replaced String.startsWith by cactoos scalar StartsWith

2da848e

(yegor256#1011) Fixed violations

3dc442c

0crat added scope role/REV labels Feb 26, 2020

paulodamaso suggested changes Feb 26, 2020

View reviewed changes

0crat assigned paulodamaso Feb 26, 2020

paulodamaso merged commit e717735 into yegor256:master Mar 12, 2020

0crat removed the scope label Mar 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#1011) Replaced String.startsWith by cactoos scalar StartsWith #1034

(#1011) Replaced String.startsWith by cactoos scalar StartsWith #1034

fanifieiev commented Feb 26, 2020

0crat commented Feb 26, 2020

paulodamaso left a comment

paulodamaso Feb 26, 2020

paulodamaso Feb 26, 2020

fanifieiev Feb 26, 2020

paulodamaso Feb 26, 2020

fanifieiev Feb 26, 2020

paulodamaso Feb 26, 2020

fanifieiev Feb 26, 2020

paulodamaso commented Feb 26, 2020

0crat commented Feb 26, 2020

0crat commented Feb 26, 2020

fanifieiev commented Mar 2, 2020

paulodamaso commented Mar 3, 2020

paulodamaso commented Mar 3, 2020

rultor commented Mar 3, 2020

rultor commented Mar 3, 2020

paulodamaso commented Mar 9, 2020

rultor commented Mar 9, 2020

paulodamaso commented Mar 9, 2020

rultor commented Mar 9, 2020

rultor commented Mar 9, 2020

0crat commented Mar 12, 2020

0crat commented Mar 12, 2020

(#1011) Replaced String.startsWith by cactoos scalar StartsWith #1034

(#1011) Replaced String.startsWith by cactoos scalar StartsWith #1034

Conversation

fanifieiev commented Feb 26, 2020

0crat commented Feb 26, 2020

paulodamaso left a comment

Choose a reason for hiding this comment

paulodamaso Feb 26, 2020

Choose a reason for hiding this comment

paulodamaso Feb 26, 2020

Choose a reason for hiding this comment

fanifieiev Feb 26, 2020

Choose a reason for hiding this comment

paulodamaso Feb 26, 2020

Choose a reason for hiding this comment

fanifieiev Feb 26, 2020

Choose a reason for hiding this comment

paulodamaso Feb 26, 2020

Choose a reason for hiding this comment

fanifieiev Feb 26, 2020

Choose a reason for hiding this comment

paulodamaso commented Feb 26, 2020

0crat commented Feb 26, 2020

0crat commented Feb 26, 2020

fanifieiev commented Mar 2, 2020

paulodamaso commented Mar 3, 2020

paulodamaso commented Mar 3, 2020

rultor commented Mar 3, 2020

rultor commented Mar 3, 2020

paulodamaso commented Mar 9, 2020

rultor commented Mar 9, 2020

paulodamaso commented Mar 9, 2020

rultor commented Mar 9, 2020

rultor commented Mar 9, 2020

0crat commented Mar 12, 2020

0crat commented Mar 12, 2020