(#1019) Simplified conditional statement with EO way #1045

fanifieiev · 2020-03-25T05:00:40Z

This PR is for #1019

0crat · 2020-03-25T05:30:58Z

This pull request #1045 is assigned to @lucasmessias9898 /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

paulodamaso · 2020-04-02T13:45:03Z

@0crat refuse

0crat · 2020-04-02T13:56:26Z

@0crat refuse (here)

@paulodamaso The user @lucasmessias9898 /z resigned from #1045, please stop working. Reason for job resignation: Order was cancelled

paulodamaso

@fanifieiev Thank you, sorry for the delay

paulodamaso · 2020-04-23T03:41:33Z

@rultor merge

rultor · 2020-04-23T03:42:32Z

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-04-23T03:51:48Z

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 9min)

paulodamaso · 2020-04-23T03:59:55Z

@rultor release tag is 1.20

rultor · 2020-04-23T04:01:07Z

@rultor release tag is 1.20

@paulodamaso OK, I will release it now. Please check the progress here

rultor · 2020-04-23T04:06:47Z

@rultor release tag is 1.20

@fanifieiev @paulodamaso Oops, I failed. You can see the full log here (spent 5min)

    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.StreamAllocation.findConnection (\u001b[1mStreamAllocation.java:186\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.StreamAllocation.findHealthyConnection (\u001b[1mStreamAllocation.java:121\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.StreamAllocation.newStream (\u001b[1mStreamAllocation.java:100\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.ConnectInterceptor.intercept (\u001b[1mConnectInterceptor.java:42\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.cache.CacheInterceptor.intercept (\u001b[1mCacheInterceptor.java:93\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.BridgeInterceptor.intercept (\u001b[1mBridgeInterceptor.java:93\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RetryAndFollowUpInterceptor.intercept (\u001b[1mRetryAndFollowUpInterceptor.java:120\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.RealCall.getResponseWithInterceptorChain (\u001b[1mRealCall.java:179\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.RealCall.execute (\u001b[1mRealCall.java:63\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.ServerConnection.callUrl (\u001b[1mServerConnection.java:113\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.ServerConnection.downloadString (\u001b[1mServerConnection.java:98\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.Jars.getBootstrapIndex (\u001b[1mJars.java:96\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.Jars.getScannerEngineFiles (\u001b[1mJars.java:76\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.Jars.download (\u001b[1mJars.java:70\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.JarDownloader.download (\u001b[1mJarDownloader.java:39\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory$1.run (\u001b[1mIsolatedLauncherFactory.java:75\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory$1.run (\u001b[1mIsolatedLauncherFactory.java:71\u001b[m)
    \u001b[1mat\u001b[m java.security.AccessController.doPrivileged (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory.createLauncher (\u001b[1mIsolatedLauncherFactory.java:71\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory.createLauncher (\u001b[1mIsolatedLauncherFactory.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.EmbeddedScanner.doStart (\u001b[1mEmbeddedScanner.java:218\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.EmbeddedScanner.start (\u001b[1mEmbeddedScanner.java:156\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.maven.bootstrap.ScannerBootstrapper.execute (\u001b[1mScannerBootstrapper.java:59\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.maven.SonarQubeMojo.execute (\u001b[1mSonarQubeMojo.java:139\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (\u001b[1mDefaultBuildPluginManager.java:137\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:210\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:156\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:148\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:117\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:81\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (\u001b[1mSingleThreadedBuilder.java:56\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleStarter.execute (\u001b[1mLifecycleStarter.java:128\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:305\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:192\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.execute (\u001b[1mDefaultMaven.java:105\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.execute (\u001b[1mMavenCli.java:956\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.doMain (\u001b[1mMavenCli.java:288\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.main (\u001b[1mMavenCli.java:192\u001b[m)
    \u001b[1mat\u001b[m sun.reflect.NativeMethodAccessorImpl.invoke0 (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m sun.reflect.NativeMethodAccessorImpl.invoke (\u001b[1mNativeMethodAccessorImpl.java:62\u001b[m)
    \u001b[1mat\u001b[m sun.reflect.DelegatingMethodAccessorImpl.invoke (\u001b[1mDelegatingMethodAccessorImpl.java:43\u001b[m)
    \u001b[1mat\u001b[m java.lang.reflect.Method.invoke (\u001b[1mMethod.java:498\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (\u001b[1mLauncher.java:282\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launch (\u001b[1mLauncher.java:225\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (\u001b[1mLauncher.java:406\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.main (\u001b[1mLauncher.java:347\u001b[m)
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] Re-run Maven using the \u001b[1m-X\u001b[m switch to enable full debug logging.
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] For more information about the errors and possible solutions, please read the following articles:
[\u001b[1;31mERROR\u001b[m] \u001b[1m[Help 1]\u001b[m http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container 99c3e2f37ccd8a04ec13b888fedb12913ed7e36d5b1af71dcad6135091a07e94 is dead
Thu Apr 23 06:06:40 CEST 2020

paulodamaso · 2020-04-23T04:09:53Z

@rultor release tag is 1.20

rultor · 2020-04-23T04:10:35Z

@rultor release tag is 1.20

@paulodamaso OK, I will release it now. Please check the progress here

rultor · 2020-04-23T04:16:13Z

@rultor release tag is 1.20

@fanifieiev @paulodamaso Oops, I failed. You can see the full log here (spent 5min)

    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.StreamAllocation.findConnection (\u001b[1mStreamAllocation.java:186\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.StreamAllocation.findHealthyConnection (\u001b[1mStreamAllocation.java:121\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.StreamAllocation.newStream (\u001b[1mStreamAllocation.java:100\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.connection.ConnectInterceptor.intercept (\u001b[1mConnectInterceptor.java:42\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.cache.CacheInterceptor.intercept (\u001b[1mCacheInterceptor.java:93\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.BridgeInterceptor.intercept (\u001b[1mBridgeInterceptor.java:93\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RetryAndFollowUpInterceptor.intercept (\u001b[1mRetryAndFollowUpInterceptor.java:120\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:92\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.internal.http.RealInterceptorChain.proceed (\u001b[1mRealInterceptorChain.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.RealCall.getResponseWithInterceptorChain (\u001b[1mRealCall.java:179\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.shaded.okhttp.RealCall.execute (\u001b[1mRealCall.java:63\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.ServerConnection.callUrl (\u001b[1mServerConnection.java:113\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.ServerConnection.downloadString (\u001b[1mServerConnection.java:98\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.Jars.getBootstrapIndex (\u001b[1mJars.java:96\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.Jars.getScannerEngineFiles (\u001b[1mJars.java:76\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.Jars.download (\u001b[1mJars.java:70\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.JarDownloader.download (\u001b[1mJarDownloader.java:39\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory$1.run (\u001b[1mIsolatedLauncherFactory.java:75\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory$1.run (\u001b[1mIsolatedLauncherFactory.java:71\u001b[m)
    \u001b[1mat\u001b[m java.security.AccessController.doPrivileged (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory.createLauncher (\u001b[1mIsolatedLauncherFactory.java:71\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.internal.IsolatedLauncherFactory.createLauncher (\u001b[1mIsolatedLauncherFactory.java:67\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.EmbeddedScanner.doStart (\u001b[1mEmbeddedScanner.java:218\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.api.EmbeddedScanner.start (\u001b[1mEmbeddedScanner.java:156\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.maven.bootstrap.ScannerBootstrapper.execute (\u001b[1mScannerBootstrapper.java:59\u001b[m)
    \u001b[1mat\u001b[m org.sonarsource.scanner.maven.SonarQubeMojo.execute (\u001b[1mSonarQubeMojo.java:139\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (\u001b[1mDefaultBuildPluginManager.java:137\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:210\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:156\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.MojoExecutor.execute (\u001b[1mMojoExecutor.java:148\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:117\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (\u001b[1mLifecycleModuleBuilder.java:81\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (\u001b[1mSingleThreadedBuilder.java:56\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.lifecycle.internal.LifecycleStarter.execute (\u001b[1mLifecycleStarter.java:128\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:305\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.doExecute (\u001b[1mDefaultMaven.java:192\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.DefaultMaven.execute (\u001b[1mDefaultMaven.java:105\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.execute (\u001b[1mMavenCli.java:956\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.doMain (\u001b[1mMavenCli.java:288\u001b[m)
    \u001b[1mat\u001b[m org.apache.maven.cli.MavenCli.main (\u001b[1mMavenCli.java:192\u001b[m)
    \u001b[1mat\u001b[m sun.reflect.NativeMethodAccessorImpl.invoke0 (\u001b[1mNative Method\u001b[m)
    \u001b[1mat\u001b[m sun.reflect.NativeMethodAccessorImpl.invoke (\u001b[1mNativeMethodAccessorImpl.java:62\u001b[m)
    \u001b[1mat\u001b[m sun.reflect.DelegatingMethodAccessorImpl.invoke (\u001b[1mDelegatingMethodAccessorImpl.java:43\u001b[m)
    \u001b[1mat\u001b[m java.lang.reflect.Method.invoke (\u001b[1mMethod.java:498\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (\u001b[1mLauncher.java:282\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.launch (\u001b[1mLauncher.java:225\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (\u001b[1mLauncher.java:406\u001b[m)
    \u001b[1mat\u001b[m org.codehaus.plexus.classworlds.launcher.Launcher.main (\u001b[1mLauncher.java:347\u001b[m)
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] Re-run Maven using the \u001b[1m-X\u001b[m switch to enable full debug logging.
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] For more information about the errors and possible solutions, please read the following articles:
[\u001b[1;31mERROR\u001b[m] \u001b[1m[Help 1]\u001b[m http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container 9ffa87b2b26eb070c036db880916c505a46f07680a71ad3e9fc05f247d518b69 is dead
Thu Apr 23 06:16:06 CEST 2020

paulodamaso · 2020-04-26T04:41:33Z

@0crat out

0crat · 2020-04-26T04:44:23Z

@0crat out (here)

@paulodamaso Job gh:yegor256/takes#1045 is not assigned, can't get performer

(yegor256#1019) Simplified conditional statement with EO way

85e4edc

0crat added scope role/REV labels Mar 25, 2020

paulodamaso approved these changes Apr 23, 2020

View reviewed changes

rultor merged commit ebbc71e into yegor256:master Apr 23, 2020

0crat removed the scope label Apr 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#1019) Simplified conditional statement with EO way #1045

(#1019) Simplified conditional statement with EO way #1045

fanifieiev commented Mar 25, 2020

0crat commented Mar 25, 2020

paulodamaso commented Apr 2, 2020

0crat commented Apr 2, 2020

paulodamaso left a comment

paulodamaso commented Apr 23, 2020

rultor commented Apr 23, 2020

rultor commented Apr 23, 2020

paulodamaso commented Apr 23, 2020

rultor commented Apr 23, 2020

rultor commented Apr 23, 2020

paulodamaso commented Apr 23, 2020

rultor commented Apr 23, 2020

rultor commented Apr 23, 2020

paulodamaso commented Apr 26, 2020

0crat commented Apr 26, 2020

(#1019) Simplified conditional statement with EO way #1045

(#1019) Simplified conditional statement with EO way #1045

Conversation

fanifieiev commented Mar 25, 2020

0crat commented Mar 25, 2020

paulodamaso commented Apr 2, 2020

0crat commented Apr 2, 2020

paulodamaso left a comment

Choose a reason for hiding this comment

paulodamaso commented Apr 23, 2020

rultor commented Apr 23, 2020

rultor commented Apr 23, 2020

paulodamaso commented Apr 23, 2020

rultor commented Apr 23, 2020

rultor commented Apr 23, 2020

paulodamaso commented Apr 23, 2020

rultor commented Apr 23, 2020

rultor commented Apr 23, 2020

paulodamaso commented Apr 26, 2020

0crat commented Apr 26, 2020