-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1088) Improve test coverage #1094
Conversation
@andreoss Please, see my new changes. |
@baudoliver7 Sorry, I meant using cactoos instead of |
@victornoel ping |
@baudoliver7 I'm not involved in takes :) |
@0crat status |
@victornoel This is what I know about this job in C3FFK3YAY, as in §32:
|
@victornoel Excuse me. it was a mistake. This ping was for @paulodamaso. |
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@baudoliver7 @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@baudoliver7 @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@baudoliver7 @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
|
@paulodamaso |
@yegor256 Please, could you merge now ? Previous mergers failed because of rultor troubles. But it has been solved. |
@rultor merge |
@baudoliver7 @yegor256 Oops, I failed. You can see the full log here (spent 5min)
|
@yegor256 After investigating, I thing you have to add theses environment variables in env:
MAVEN_OPTS: -XX:MaxPermSize=256m -Xmx1g
JAVA_OPTS: -XX:MaxPermSize=256m -Xmx1g |
@rultor merge |
@baudoliver7 @yegor256 Oops, I failed. You can see the full log here (spent 3min)
|
@yegor256 The issue is about I noticed that since version When I execute this command in latest version of docker run -it yegor256/rultor-image -c "update-java-alternatives --list" I get this : java-1.11.0-openjdk-amd64 1111 /usr/lib/jvm/java-1.11.0-openjdk-amd64 Which justifies previous error message from update-java-alternatives: directory does not exist: /usr/lib/jvm/java-1.8.0-openjdk-amd64 To install and set apt install openjdk-8-jdk -y && \
update-alternatives --set java /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java && \
update-alternatives --set javac /usr/lib/jvm/java-8-openjdk-amd64/bin/javac Because I noticed that You can also revert all other changes made in Hope it helps :) |
@yegor256 please, have a look on my suggestion. |
@rultor merge |
@baudoliver7 @yegor256 Oops, I failed. You can see the full log here (spent 3min)
|
@baudoliver7 check your code, it seems that the defect is there |
9519206
to
3bea758
Compare
@yegor256 fixed now. Could you try again ? |
@rultor merge |
@baudoliver7 @yegor256 Oops, I failed. You can see the full log here (spent 12min)
|
@rultor merge |
@baudoliver7 thanks! |
For #1088