-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1062: Bump Cactoos for org.cactoos.text.Sticky #1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Please, see my comments.
).value(), | ||
origin.head() | ||
return new Mapped<>( | ||
Text::asString, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Why don't you use Text::toString
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baudoliver7 toString
is not Text
method, basically it would be the same as Object::toString
. Mapped
handles checked exception here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss But, if toString()
is implemented in Text
, we can use it (I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -93,15 +93,15 @@ public RqFormBase(final Request request) { | |||
new FormattedText( | |||
"there are no params \"%s\" among %d others: %s", | |||
key, this.map().size(), this.map().keySet() | |||
).asString() | |||
).toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Is it mandatory to use toString
?
); | ||
} else { | ||
iter = new VerboseIterable<>( | ||
values, | ||
new FormattedText( | ||
"there are only %d params by name \"%s\"", | ||
values.size(), key | ||
).asString() | ||
).toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Ditto
@@ -65,7 +65,7 @@ void readsOneChunk() throws IOException { | |||
data, | |||
ChunkedInputStreamTest.END_OF_CHUNK, | |||
"" | |||
).asString(), | |||
).toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Is it mandatory to use toString
?
@@ -102,7 +102,7 @@ void readsManyChunks() throws IOException { | |||
third, | |||
ChunkedInputStreamTest.END_OF_CHUNK, | |||
"" | |||
).asString(), | |||
).toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Ditto
@@ -133,7 +133,7 @@ void ignoresParameterAfterSemiColon() throws IOException { | |||
data, | |||
ChunkedInputStreamTest.END_OF_CHUNK, | |||
"" | |||
).asString(), | |||
).toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss Is it mandatory to use toString
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baudoliver7 The signature has changed and asString
now throws Exception
instead of IOException
. (see https://github.com/yegor256/cactoos/blob/0.35/src/main/java/org/cactoos/text/TextEnvelope.java#L62).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss I was asking this because sometimes, toString()
is called implicitly. But in these cases, you are right.
@baudoliver7 I removed explicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss It's ok for me.
@paulodamaso Please, check/merge.
@rultor merge |
@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 2min)
|
@rultor merge |
@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 3min)
|
@rultor merge |
@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 2min)
|
@andreoss any ideas what's going on here? |
@yegor256 Looks like the key has expired or got removed |
@yegor256 It also works for eight digits key (9AF0FA4C). |
@rultor merge |
@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 2min)
|
@yegor256 You still use GPG key server |
@yegor256 Perhaps, you should upgrade |
@baudoliver7 the error happens even before Docker container starts :( |
@yegor256 If I understand correctly, we are already in Docker container at this step :
Because we are supposed to clone |
@rultor merge |
@andreoss @baudoliver7 magic happened! thanks to all! |
Code review was too long (128 days), architects (@paulodamaso) were penalized, see §55 |
@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality good |
@0crat status |
@baudoliver7 This is what I know about this job in C3FFK3YAY, as in §32:
|
@0crat status |
@0crat quality good |
Per #1062