Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1062: Bump Cactoos for org.cactoos.text.Sticky #1104

Merged
merged 12 commits into from
Sep 1, 2021

Conversation

andreoss
Copy link
Contributor

@andreoss andreoss commented Apr 26, 2021

Per #1062

  • Upgrade cactoos
  • Use Sticky

@andreoss andreoss marked this pull request as ready for review April 26, 2021 02:15
Copy link
Contributor

@baudoliver7 baudoliver7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Please, see my comments.

).value(),
origin.head()
return new Mapped<>(
Text::asString,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Why don't you use Text::toString ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baudoliver7 toString is not Text method, basically it would be the same as Object::toString. Mapped handles checked exception here.

Copy link
Contributor

@baudoliver7 baudoliver7 Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss But, if toString() is implemented in Text, we can use it (I think).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -93,15 +93,15 @@ public RqFormBase(final Request request) {
new FormattedText(
"there are no params \"%s\" among %d others: %s",
key, this.map().size(), this.map().keySet()
).asString()
).toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Is it mandatory to use toString ?

);
} else {
iter = new VerboseIterable<>(
values,
new FormattedText(
"there are only %d params by name \"%s\"",
values.size(), key
).asString()
).toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Ditto

@@ -65,7 +65,7 @@ void readsOneChunk() throws IOException {
data,
ChunkedInputStreamTest.END_OF_CHUNK,
""
).asString(),
).toString(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Is it mandatory to use toString ?

@@ -102,7 +102,7 @@ void readsManyChunks() throws IOException {
third,
ChunkedInputStreamTest.END_OF_CHUNK,
""
).asString(),
).toString(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Ditto

@@ -133,7 +133,7 @@ void ignoresParameterAfterSemiColon() throws IOException {
data,
ChunkedInputStreamTest.END_OF_CHUNK,
""
).asString(),
).toString(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss Is it mandatory to use toString ?

Copy link
Contributor Author

@andreoss andreoss Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baudoliver7 The signature has changed and asString now throws Exception instead of IOException. (see https://github.com/yegor256/cactoos/blob/0.35/src/main/java/org/cactoos/text/TextEnvelope.java#L62).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss I was asking this because sometimes, toString() is called implicitly. But in these cases, you are right.

@andreoss
Copy link
Contributor Author

@baudoliver7 I removed explicit toString

Copy link
Contributor

@baudoliver7 baudoliver7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss It's ok for me.
@paulodamaso Please, check/merge.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 29, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Aug 29, 2021

@rultor merge

@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 2min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 20895
+ echo '1.70.1 902cdb23c'
1.70.1 902cdb23c
+ date
Sun Aug 29 16:04:39 CEST 2021
+ uptime
 16:04:39 up 336 days, 10 min,  0 users,  load average: 4.16, 4.34, 4.51
+ ff=default
+ image=yegor256/rultor-image:1.3
+ rebase=false
+ head_branch=master
+ pull_title='#1062: Bump Cactoos for org.cactoos.text.Sticky'
+ author=yegor256
+ directory=
+ head=git@github.com:yegor256/takes.git
+ pull_id=1104
+ fork=git@github.com:andreoss/takes.git
+ fork_branch=issue-1062
+ squash=false
+ vars=('--env=head=git@github.com:yegor256/takes.git' '--env=pull_id=1104' '--env=fork=git@github.com:andreoss/takes.git' '--env=fork_branch=issue-1062' '--env=head_branch=master' '--env=pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky' '--env=author=yegor256' '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:yegor256/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=1104'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:andreoss/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-1062'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=yegor256'\''\'\'''\'''\'' '\'';'\'' '\''sudo update-java-alternatives -s java-1.8.0-openjdk-amd64'\'' '\'';'\'' '\''export LC_ALL=en_US.UTF-8'\'' '\'';'\'' '\''export LANG=en_US.UTF-8'\'' '\'';'\'' '\''export LANGUAGE=en_US.UTF-8'\'' '\'';'\'' '\''mvn clean install -Pqulice --errors --settings ../settings.xml'\'' '\'';'\'' '\''mvn clean site -Psite --errors --settings ../settings.xml'\'' '\'';'\'' '\''pdd --source=$(pwd) --verbose --file=/dev/null'\'' '\'';'\'' )')
+ scripts=('export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';')
+ container=yegor256_takes_1104
+ as_root=false
+ git --version
git version 2.7.4
+ docker --version
Docker version 17.12.0-ce, build c97c6d6
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:yegor256/takes.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''head=git@github.com:yegor256/takes.git'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
?: pool.sks-keyservers.net: Host not found
gpgkeys: HTTP fetch error 7: couldn't connect: Success
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver unreachable
gpg: keyserver communications error: public key not found
gpg: keyserver receive failed: public key not found
'cid' file is absent, container wasn't started correctly

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 29, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Aug 29, 2021

@rultor merge

@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 3min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 23615
+ echo '2.0-SNAPSHOT BUILD'
2.0-SNAPSHOT BUILD
+ date
Sun Aug 29 16:16:37 CEST 2021
+ uptime
 16:16:37 up 336 days, 22 min,  0 users,  load average: 4.36, 4.52, 4.57
+ ff=default
+ image=yegor256/rultor-image:1.3
+ rebase=false
+ head_branch=master
+ pull_title='#1062: Bump Cactoos for org.cactoos.text.Sticky'
+ author=yegor256
+ directory=
+ head=git@github.com:yegor256/takes.git
+ pull_id=1104
+ fork=git@github.com:andreoss/takes.git
+ fork_branch=issue-1062
+ squash=false
+ vars=('--env=head=git@github.com:yegor256/takes.git' '--env=pull_id=1104' '--env=fork=git@github.com:andreoss/takes.git' '--env=fork_branch=issue-1062' '--env=head_branch=master' '--env=pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky' '--env=author=yegor256' '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:yegor256/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=1104'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:andreoss/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-1062'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=yegor256'\''\'\'''\'''\'' '\'';'\'' '\''sudo update-java-alternatives -s java-1.8.0-openjdk-amd64'\'' '\'';'\'' '\''export LC_ALL=en_US.UTF-8'\'' '\'';'\'' '\''export LANG=en_US.UTF-8'\'' '\'';'\'' '\''export LANGUAGE=en_US.UTF-8'\'' '\'';'\'' '\''mvn clean install -Pqulice --errors --settings ../settings.xml'\'' '\'';'\'' '\''mvn clean site -Psite --errors --settings ../settings.xml'\'' '\'';'\'' '\''pdd --source=$(pwd) --verbose --file=/dev/null'\'' '\'';'\'' )')
+ scripts=('export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';')
+ container=yegor256_takes_1104
+ as_root=false
+ git --version
git version 2.7.4
+ docker --version
Docker version 17.12.0-ce, build c97c6d6
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:yegor256/takes.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''head=git@github.com:yegor256/takes.git'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver keys.openpgp.org --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server keys.openpgp.org
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 29, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Aug 29, 2021

@rultor merge

@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 2min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 2333
+ echo '1.70.3 d1d7f8d6a'
1.70.3 d1d7f8d6a
+ date
Sun Aug 29 16:52:42 CEST 2021
+ uptime
 16:52:42 up 336 days, 58 min,  0 users,  load average: 4.18, 4.43, 4.66
+ ff=default
+ image=yegor256/rultor-image:1.3
+ rebase=false
+ head_branch=master
+ pull_title='#1062: Bump Cactoos for org.cactoos.text.Sticky'
+ author=yegor256
+ directory=
+ head=git@github.com:yegor256/takes.git
+ pull_id=1104
+ fork=git@github.com:andreoss/takes.git
+ fork_branch=issue-1062
+ squash=false
+ vars=('--env=head=git@github.com:yegor256/takes.git' '--env=pull_id=1104' '--env=fork=git@github.com:andreoss/takes.git' '--env=fork_branch=issue-1062' '--env=head_branch=master' '--env=pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky' '--env=author=yegor256' '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:yegor256/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=1104'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:andreoss/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-1062'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=yegor256'\''\'\'''\'''\'' '\'';'\'' '\''sudo update-java-alternatives -s java-1.8.0-openjdk-amd64'\'' '\'';'\'' '\''export LC_ALL=en_US.UTF-8'\'' '\'';'\'' '\''export LANG=en_US.UTF-8'\'' '\'';'\'' '\''export LANGUAGE=en_US.UTF-8'\'' '\'';'\'' '\''mvn clean install -Pqulice --errors --settings ../settings.xml'\'' '\'';'\'' '\''mvn clean site -Psite --errors --settings ../settings.xml'\'' '\'';'\'' '\''pdd --source=$(pwd) --verbose --file=/dev/null'\'' '\'';'\'' )')
+ scripts=('export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';')
+ container=yegor256_takes_1104
+ as_root=false
+ git --version
git version 2.7.4
+ docker --version
Docker version 17.12.0-ce, build c97c6d6
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:yegor256/takes.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''head=git@github.com:yegor256/takes.git'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server keys.gnupg.net
?: keys.gnupg.net: Host not found
gpgkeys: HTTP fetch error 7: couldn't connect: Success
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver unreachable
gpg: keyserver communications error: public key not found
gpg: keyserver receive failed: public key not found
'cid' file is absent, container wasn't started correctly

@yegor256
Copy link
Owner

@andreoss any ideas what's going on here?

@andreoss
Copy link
Contributor Author

@yegor256 Looks like the key has expired or got removed

@baudoliver7
Copy link
Contributor

@yegor256 It also works for eight digits key (9AF0FA4C).

@yegor256
Copy link
Owner

yegor256 commented Sep 1, 2021

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 1, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Sep 1, 2021

@rultor merge

@andreoss @yegor256 Oops, I failed. You can see the full log here (spent 2min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 10085
+ echo '1.70.5 e3510d350'
1.70.5 e3510d350
+ date
Wed Sep  1 13:06:03 CEST 2021
+ uptime
 13:06:03 up 338 days, 21:12,  0 users,  load average: 4.43, 4.54, 4.56
+ ff=default
+ image=yegor256/rultor-image:1.3
+ rebase=false
+ head_branch=master
+ pull_title='#1062: Bump Cactoos for org.cactoos.text.Sticky'
+ author=yegor256
+ directory=
+ head=git@github.com:yegor256/takes.git
+ pull_id=1104
+ fork=git@github.com:andreoss/takes.git
+ fork_branch=issue-1062
+ squash=false
+ vars=('--env=head=git@github.com:yegor256/takes.git' '--env=pull_id=1104' '--env=fork=git@github.com:andreoss/takes.git' '--env=fork_branch=issue-1062' '--env=head_branch=master' '--env=pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky' '--env=author=yegor256' '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:yegor256/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=1104'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:andreoss/takes.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-1062'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=yegor256'\''\'\'''\'''\'' '\'';'\'' '\''sudo update-java-alternatives -s java-1.8.0-openjdk-amd64'\'' '\'';'\'' '\''export LC_ALL=en_US.UTF-8'\'' '\'';'\'' '\''export LANG=en_US.UTF-8'\'' '\'';'\'' '\''export LANGUAGE=en_US.UTF-8'\'' '\'';'\'' '\''mvn clean install -Pqulice --errors --settings ../settings.xml'\'' '\'';'\'' '\''mvn clean site -Psite --errors --settings ../settings.xml'\'' '\'';'\'' '\''pdd --source=$(pwd) --verbose --file=/dev/null'\'' '\'';'\'' )')
+ scripts=('export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';')
+ container=yegor256_takes_1104
+ as_root=false
+ git --version
git version 2.7.4
+ docker --version
Docker version 17.12.0-ce, build c97c6d6
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:yegor256/takes.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''head=git@github.com:yegor256/takes.git'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''head=git@github.com:yegor256/takes.git'\''' ';' 'export '\''pull_id=1104'\''' ';' 'export '\''fork=git@github.com:andreoss/takes.git'\''' ';' 'export '\''fork_branch=issue-1062'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#1062: Bump Cactoos for org.cactoos.text.Sticky'\''' ';' 'export '\''author=yegor256'\''' ';' 'sudo update-java-alternatives -s java-1.8.0-openjdk-amd64' ';' 'export LC_ALL=en_US.UTF-8' ';' 'export LANG=en_US.UTF-8' ';' 'export LANGUAGE=en_US.UTF-8' ';' 'mvn clean install -Pqulice --errors --settings ../settings.xml' ';' 'mvn clean site -Psite --errors --settings ../settings.xml' ';' 'pdd --source=$(pwd) --verbose --file=/dev/null' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver keys.openpgp.org --verbose --recv-keys 3FD3FA7E9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server keys.openpgp.org
gpgkeys: key 3FD3FA7E9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly

@baudoliver7
Copy link
Contributor

@yegor256 You still use GPG key server keys.openpgp.org. Could you use keyserver.ubuntu.com instead ?

@baudoliver7
Copy link
Contributor

@yegor256 Perhaps, you should upgrade rultor-image version to 1.6 (it's currently 1.3) because I see in this version that you use keyserver.ubuntu.com instead.

@baudoliver7
Copy link
Contributor

@yegor256 Here is how I implement my .rultor.yml file. By this way, I always take the latest version of rultor-image.

yegor256 added a commit that referenced this pull request Sep 1, 2021
@yegor256
Copy link
Owner

yegor256 commented Sep 1, 2021

@baudoliver7 the error happens even before Docker container starts :(

@baudoliver7
Copy link
Contributor

@yegor256 If I understand correctly, we are already in Docker container at this step :

Docker version 17.12.0-ce, build c97c6d6
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:yegor256/takes.git repo

Because we are supposed to clone takes repo in rultor-image container.
Could you attempt to merge now ?

@yegor256
Copy link
Owner

yegor256 commented Sep 1, 2021

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 1, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6122155 into yegor256:master Sep 1, 2021
@rultor
Copy link
Collaborator

rultor commented Sep 1, 2021

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@yegor256
Copy link
Owner

yegor256 commented Sep 1, 2021

@andreoss @baudoliver7 magic happened! thanks to all!

@0crat
Copy link
Collaborator

0crat commented Sep 1, 2021

Code review was too long (128 days), architects (@paulodamaso) were penalized, see §55

@0crat 0crat added qa and removed 0crat/scope labels Sep 1, 2021
@0crat
Copy link
Collaborator

0crat commented Sep 1, 2021

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality good

@baudoliver7
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Sep 4, 2021

@0crat status (here)

@baudoliver7 This is what I know about this job in C3FFK3YAY, as in §32:

@baudoliver7
Copy link
Contributor

@0crat status

4 similar comments
@baudoliver7
Copy link
Contributor

@0crat status

@baudoliver7
Copy link
Contributor

@0crat status

@baudoliver7
Copy link
Contributor

@0crat status

@baudoliver7
Copy link
Contributor

@0crat status

@sereshqua
Copy link

@0crat quality good

@baudoliver7
Copy link
Contributor

@yegor256 although the qa step is finished, @0crat doesn't reward and remove task from Agenda.

@0crat
Copy link
Collaborator

0crat commented Oct 25, 2021

Are you speaking to me or about me here; you must always start your message with my name if you want to address it to me, see §1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants