#111 FIX: VerboseIterable and VerboseIterator are not tested #218

marcuss · 2015-04-29T04:13:45Z

@yegor256 This pull request fixes bug #111 that identified the missing unit tests in VerboseIterable and VerboseIterator, for fixing this, the VerboseIterableTest and VerboseIteratorTest classes were created.

marcuss · 2015-04-29T04:24:13Z

@yegor256 this is my first pull request, I see the CI kicking in, but there is apparently a non deterministic test on
FtBasicTest.gracefullyHandlesStuckBack

I can't reproduce it locally, but since I din't change code, just added unit test is not normal that my build has errors

:144 HTTP response body content is not valid:
200 OK [http://localhost:1050/]
Content-Type: text/plain

first: , second:
Expected: a string containing "second: dd"
but: was "first: , second: "

davvd · 2015-04-29T09:20:31Z

@M4Solutions Thanks for your pull request, let me find someone who can review it

davvd · 2015-04-29T09:28:19Z

@pinaf it's yours, please review

pinaf · 2015-04-29T17:04:36Z

src/test/java/org/takes/misc/VerboseIterableTest.java

+			"Accept-Charset: utf-8",
+			"Authorization: Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==",
+			"Cache-Control: no-cache", "From: user@example.com");
+


@M4Solutions Add a javadoc comment here with the form VerboseIterable can .... I suggest:

/** * VerboseIterable can return correct size. */

pinaf · 2015-04-29T17:25:57Z

@M4Solutions 20 comments and 1 question above.

yegor256 · 2015-05-04T04:33:30Z

@rultor try to merge

rultor · 2015-05-04T04:34:22Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-05-04T04:42:07Z

@rultor try to merge

@yegor256 Oops, I failed. You can see the full log here (spent 8min)

Running org.takes.facets.auth.social.PsTwitterTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.takes.facets.auth.social.PsTwitterTest

Results :

Tests in error: 
  RqMultipartTest.consumesHttpRequest:303 » IO Failed POST request to http://loc...

Tests run: 168, Failures: 0, Errors: 1, Skipped: 4

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53.675 s
[INFO] Finished at: 2015-05-04T04:41:57+00:00
[INFO] Final Memory: 27M/388M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project takes: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project takes: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:195)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:861)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:729)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

marcuss · 2015-05-07T03:47:47Z

@pinaf Should I close this pull request now that the problem in master has been skipped?

pinaf · 2015-05-07T03:55:16Z

@rultor merge
@marcuss we should try to merge again

rultor · 2015-05-07T03:55:31Z

@rultor merge
@marcuss we should try to merge again

@pinaf Thanks for your request. @yegor256 Please confirm this.

pinaf · 2015-05-07T03:56:33Z

@marcuss @yegor256 both of you have unaddressed comments. please go through your comments and make sure all of them address somebody.

marcuss · 2015-05-07T04:02:13Z

@pinaf I just corrected my unaddressed comments.

yegor256 · 2015-05-07T05:32:00Z

@marcuss see above

yegor256 · 2015-05-07T17:51:49Z

@rultor merge

rultor · 2015-05-07T18:38:47Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-05-07T18:48:02Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

pinaf · 2015-05-07T20:43:49Z

@marcuss thanks. also make sure that the first post explains what issue this is for and what your solution was. here is some important info on QA http://www.teamed.io/qa.html

davvd · 2015-05-08T19:17:14Z

@elenavolokhova review this ticket please, for compliance with our quality rules

elenavolokhova · 2015-05-09T07:49:42Z

@pinaf Thank you for your job on quality of this endless review :) But one issue is still not fixed: @yegor256 comments still don't have addressee. Please, try to be more persistent next time.

davvd · 2015-05-09T11:16:32Z

@rultor deploy

rultor · 2015-05-09T11:53:57Z

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

rultor · 2015-05-09T12:04:09Z

@rultor deploy

@davvd Done! FYI, the full log is here (took me 10min)

pinaf · 2015-05-09T19:34:38Z

@elenavolokhova alright.
@yegor256 please address your unaddressed comments :)

yegor256 · 2015-05-09T19:40:59Z

@elenavolokhova yes, I got it, will be more attentive in the future, thanks!

elenavolokhova · 2015-05-11T04:50:07Z

@davvd Quality is acceptable here.

davvd · 2015-05-11T10:34:26Z

@davvd Quality is acceptable here.

@elenavolokhova thanks for the review, we'll try better next time

davvd · 2015-05-11T16:23:56Z

@pinaf just added 10 mins to @elenavolokhova (for QA), payment ID is 57161463... Much obliged! I have added 26 mins to your account in payment "AP-5SD91831XV3762709", 201 hours and 34 mins spent... extra minutes for review comments (c=11)... added +26 to your rating, now it is equal to +7835

0pdd · 2018-10-11T01:46:10Z

@marcuss all 2 puzzles are solved here: #780, #806.

Marcus Sanchez added 2 commits April 28, 2015 22:54

VerboseIterable and VerboseIterator are not tested #111 FIX

9451021

Merge branch 'master' of https://github.com/yegor256/takes

f3c963c

davvd added CR @pinaf labels Apr 29, 2015

pinaf reviewed Apr 29, 2015
View reviewed changes

Marcus Sanchez added 3 commits May 7, 2015 01:31

#111 FIX: VerboseIterable and VerboseIterator are not tested

2bb6261

Merge branch 'master' of github.com:m4solutions/takes

875b52a

Merge branch 'master' of https://github.com/yegor256/takes

cadb7c4

rultor merged commit cadb7c4 into yegor256:master May 7, 2015

marcuss mentioned this pull request May 10, 2015

VerboseIterable and VerboseIterator are not tested #111

Closed

0pdd mentioned this pull request Jan 29, 2018

Condition.java:36-41: Implement Condition.Range that... #780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#111 FIX: VerboseIterable and VerboseIterator are not tested #218

#111 FIX: VerboseIterable and VerboseIterator are not tested #218

marcuss commented Apr 29, 2015

marcuss commented Apr 29, 2015

davvd commented Apr 29, 2015

davvd commented Apr 29, 2015

pinaf Apr 29, 2015

pinaf commented Apr 29, 2015

yegor256 commented May 4, 2015

rultor commented May 4, 2015

rultor commented May 4, 2015

marcuss commented May 7, 2015

pinaf commented May 7, 2015

rultor commented May 7, 2015

pinaf commented May 7, 2015

marcuss commented May 7, 2015

yegor256 commented May 7, 2015

yegor256 commented May 7, 2015

rultor commented May 7, 2015

rultor commented May 7, 2015

pinaf commented May 7, 2015

davvd commented May 8, 2015

elenavolokhova commented May 9, 2015

davvd commented May 9, 2015

rultor commented May 9, 2015

rultor commented May 9, 2015

pinaf commented May 9, 2015

yegor256 commented May 9, 2015

elenavolokhova commented May 11, 2015

davvd commented May 11, 2015

davvd commented May 11, 2015

0pdd commented Oct 11, 2018

#111 FIX: VerboseIterable and VerboseIterator are not tested #218

#111 FIX: VerboseIterable and VerboseIterator are not tested #218

Conversation

marcuss commented Apr 29, 2015

marcuss commented Apr 29, 2015

davvd commented Apr 29, 2015

davvd commented Apr 29, 2015

pinaf Apr 29, 2015

Choose a reason for hiding this comment

pinaf commented Apr 29, 2015

yegor256 commented May 4, 2015

rultor commented May 4, 2015

rultor commented May 4, 2015

marcuss commented May 7, 2015

pinaf commented May 7, 2015

rultor commented May 7, 2015

pinaf commented May 7, 2015

marcuss commented May 7, 2015

yegor256 commented May 7, 2015

yegor256 commented May 7, 2015

rultor commented May 7, 2015

rultor commented May 7, 2015

pinaf commented May 7, 2015

davvd commented May 8, 2015

elenavolokhova commented May 9, 2015

davvd commented May 9, 2015

rultor commented May 9, 2015

rultor commented May 9, 2015

pinaf commented May 9, 2015

yegor256 commented May 9, 2015

elenavolokhova commented May 11, 2015

davvd commented May 11, 2015

davvd commented May 11, 2015

0pdd commented Oct 11, 2018