Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #485 (HmRsBody matcher for checking response body) implemented #545

Closed
wants to merge 14 commits into from
Closed

Conversation

akaigoro
Copy link

Issue #485 fixed - HmRsBody matcher for checking response body implemented, and some tests created against the new class.

@davvd
Copy link

davvd commented Jan 25, 2016

@rfqu I will find a reviewer for your pull requests shortly, thanks for contribution!

@davvd
Copy link

davvd commented Jan 25, 2016

@dmzaytsev it's yours, please review

@dmzaytsev
Copy link
Contributor

@rfqu please add description of what you did in the PR description, also include there reference to the issue you are fixing

@dmzaytsev
Copy link
Contributor

@rfqu Travis CI build failed due to using unsupported features

[ERROR] /home/travis/build/yegor256/takes/src/main/java/org/takes/facets/hamcrest/HmRsBody.java:[111,29] try-with-resources is not supported in -source 1.6
(use -source 7 or higher to enable try-with-resources)

we should use Java 6 in this project

@dmzaytsev
Copy link
Contributor

@rfqu please run full Maven build:

$ mvn clean install -Pqulice

and fix checkstyle's issues

@dmzaytsev
Copy link
Contributor

@rfqu Travis build failed. There are a few PMD violations.
please fix it

@dmzaytsev
Copy link
Contributor

@rfqu please close the pull request if you don't want work on it anymore

@akaigoro akaigoro closed this Feb 11, 2016
@davvd
Copy link

davvd commented Feb 13, 2016

@elenavolokhova please, review this ticket for compliance with our QA rules

@elenavolokhova
Copy link

@davvd Quality is acceptable here. PR was not merged, so it can't be perfect, but CR followed all our rules and should be rewarded.

@davvd
Copy link

davvd commented Feb 14, 2016

@davvd Quality is acceptable here. PR was not merged, so it can't be perfect, but CR followed all our rules and should be rewarded.

@elenavolokhova thanks a lot, next time everybody should try to make it better

@davvd
Copy link

davvd commented Feb 14, 2016

@dmzaytsev I added 10 mins to @elenavolokhova (for QA review) in transaction 77293465. 20 mins was added to your account, many thanks for your contribution (payment 77293468)! The task took 431 hours and 36 mins.. you're getting extra minutes here (c=5). +20 added to your rating, current score is: +3170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants