-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #485 (HmRsBody matcher for checking response body) implemented #545
Conversation
@rfqu I will find a reviewer for your pull requests shortly, thanks for contribution! |
@dmzaytsev it's yours, please review |
@rfqu please add description of what you did in the PR description, also include there reference to the issue you are fixing |
@rfqu Travis CI build failed due to using unsupported features
we should use Java 6 in this project |
@rfqu please run full Maven build:
and fix checkstyle's issues |
@rfqu Travis build failed. There are a few PMD violations. |
@rfqu please close the pull request if you don't want work on it anymore |
@elenavolokhova please, review this ticket for compliance with our QA rules |
@davvd Quality is acceptable here. PR was not merged, so it can't be perfect, but CR followed all our rules and should be rewarded. |
@elenavolokhova thanks a lot, next time everybody should try to make it better |
@dmzaytsev I added 10 mins to @elenavolokhova (for QA review) in transaction 77293465. 20 mins was added to your account, many thanks for your contribution (payment 77293468)! The task took 431 hours and 36 mins.. you're getting extra minutes here (c=5). +20 added to your rating, current score is: +3170 |
Issue #485 fixed - HmRsBody matcher for checking response body implemented, and some tests created against the new class.