-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base64 de/encoding #727
Base64 de/encoding #727
Conversation
@yegor256 please, pay attention to this pull request |
@semantosoph looks cool, but you have to run |
@yegor256 Done that. Qulice now runs error free for me. |
/** | ||
* A short text to encode with Base64. | ||
*/ | ||
private static final String SHORTTEXT = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yegor256 I see your point and refactored the class.
@rultor try to merge |
@semantosoph @yegor256 Oops, I failed. You can see the full log here (spent 4min)
|
Oops: "Error: M2_HOME is set to an invalid directory." @yegor256 Is there something I can do? |
@yegor256 Could you fix the appveyor (or turn it off), please? I'd like to move on here. |
@rultor try to merge again |
@semantosoph thanks! |
Hi.
I implemented a simple Base64 de/encoder (with tests) and used it to enable the CcBase64 codec and its tests. This is only the foundation for more thing to come, but these changes work for themselves and could thus be pulled separately. Also, bumped the version in pom.xml.
Regards, Sven