Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 de/encoding #727

Merged
merged 7 commits into from
Jun 7, 2017
Merged

Base64 de/encoding #727

merged 7 commits into from
Jun 7, 2017

Conversation

semantosoph
Copy link

Hi.

I implemented a simple Base64 de/encoder (with tests) and used it to enable the CcBase64 codec and its tests. This is only the foundation for more thing to come, but these changes work for themselves and could thus be pulled separately. Also, bumped the version in pom.xml.

Regards, Sven

@0crat
Copy link
Collaborator

0crat commented May 23, 2017

@yegor256 please, pay attention to this pull request

@yegor256
Copy link
Owner

@semantosoph looks cool, but you have to run mvn clean install -Pqulice and fix the problems qulice reports

@semantosoph
Copy link
Author

@yegor256 Done that. Qulice now runs error free for me.

/**
* A short text to encode with Base64.
*/
private static final String SHORTTEXT =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 I see your point and refactored the class.

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented May 24, 2017

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 24, 2017

@rultor try to merge

@semantosoph @yegor256 Oops, I failed. You can see the full log here (spent 4min)

+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2817: running'
waiting for AppVeyor build 2817: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2817
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2817: running'
waiting for AppVeyor build 2817: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2817
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2817: running'
waiting for AppVeyor build 2817: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2817
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2817: running'
waiting for AppVeyor build 2817: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2817
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 2817: running'
waiting for AppVeyor build 2817: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/2817
++ jq -r .build.status
+ status=failed
+ '[' failed == null ']'
+ '[' failed == success ']'
+ '[' failed == failed ']'
+ echo 'see https://ci.appveyor.com/project/yegor256/takes/build/2817'
see https://ci.appveyor.com/project/yegor256/takes/build/2817
+ exit 1
container fe78431c1b548a70712b1b23e686a36f76800e90ab32a53a843d231ec525f442 is dead
Wed May 24 18:35:31 CEST 2017

@semantosoph
Copy link
Author

semantosoph commented May 24, 2017

Oops: "Error: M2_HOME is set to an invalid directory."

@yegor256 Is there something I can do?

@semantosoph
Copy link
Author

@yegor256 Could you fix the appveyor (or turn it off), please? I'd like to move on here.

yegor256 added a commit that referenced this pull request Jun 7, 2017
@yegor256
Copy link
Owner

yegor256 commented Jun 7, 2017

@rultor try to merge again

@rultor
Copy link
Collaborator

rultor commented Jun 7, 2017

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5031177 into yegor256:master Jun 7, 2017
@rultor
Copy link
Collaborator

rultor commented Jun 7, 2017

@rultor try to merge again

@yegor256 Done! FYI, the full log is here (took me 29min)

@yegor256
Copy link
Owner

yegor256 commented Jun 7, 2017

@semantosoph thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants