Implementation of JSON Web Token #743

semantosoph · 2017-08-09T07:57:32Z

These commits introduce the following things in order to make JSON Web Token (JWT, see https://jwt.io/) usable in takes:

A new Signature interface, similar to the Codec interface. The main difference is that while Codecs can encrypt and decrypt data, a Signature can only encrypt (aka sign) data.
An HMAC-SHA implementation of that interface with variations of 256, 384 and 512 bitlength. This is the standard signature algorithm for JWT.
A new interface for Token and two implementations that provide a JOSE token (JWT header) and a JWT payload token.
A new Pass that accepts JWT from a Bearer header and adds a new JWT to its response (obviously, that works only with JSON responses).

0crat · 2017-08-09T07:57:35Z

@yegor256 please, pay attention to this pull request

0crat · 2017-08-09T07:57:43Z

Job gh:yegor256/takes#743 is in scope.

0crat · 2017-08-09T07:57:51Z

+15 points just awarded to @semantosoph, total is +15.

codecov-io · 2017-08-09T08:05:07Z

Codecov Report

Merging #743 into master will decrease coverage by 0.82%.
The diff coverage is 40.77%.

@@             Coverage Diff              @@
##             master     #743      +/-   ##
============================================
- Coverage     77.55%   76.72%   -0.83%     
- Complexity      900      912      +12     
============================================
  Files           205      208       +3     
  Lines          4245     4348     +103     
  Branches        323      330       +7     
============================================
+ Hits           3292     3336      +44     
- Misses          823      881      +58     
- Partials        130      131       +1

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/takes/facets/auth/PsToken.java	`0% <0%> (ø)`	`0 <0> (?)`
src/main/java/org/takes/facets/auth/Token.java	`100% <100%> (ø)`	`0 <0> (?)`
.../java/org/takes/facets/auth/signatures/SiHmac.java	`73.33% <73.33%> (ø)`	`10 <10> (?)`
src/main/java/org/takes/http/MainRemote.java	`57.37% <0%> (+1.63%)`	`7% <0%> (+1%)`	⬆️
src/main/java/org/takes/misc/Base64.java	`82.45% <0%> (+1.75%)`	`12% <0%> (+1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5888370...9448788. Read the comment docs.

yegor256 · 2017-08-09T11:45:34Z

src/main/java/org/takes/facets/auth/Token.java

+    /**
+     * JSON Web Token.
+     */
+    @SuppressWarnings


@semantosoph you can remove that and just initialize all attributes in the constructor, it's a good practice.

@yegor256 Yep, will do.

yegor256 · 2017-08-09T11:46:35Z

src/main/java/org/takes/facets/auth/Token.java

+            try {
+                bytes = new Base64().encode(this.jwto.toString());
+            } catch (final IOException ignore) {
+                bytes = new byte[] {};


@semantosoph this looks a bit weird. Why so? Can't you just throw an unchecked exception here?

@yegor256 Yeah, I don't like declaring throws on interface methods. But as of now, it looks like there will always be a reason to throw an IOException, so we can predeclare it anyway.

yegor256 · 2017-08-09T11:47:36Z

src/main/java/org/takes/facets/auth/signatures/SiHmac.java

+     * @throws IOException
+     *  for all unexpected exceptions
+     */
+    @SuppressWarnings("resource")


@semantosoph what's the point of this suppression? Can't you do what Java wants you to do?

@yegor256 This is kinda silly. Constructing the Formatter without parameters forces it to use an internal StringBuilder which is totally OK for our use. But that StringBuilder is not closable, so calling close() on the Formatter is useless in terms of saving resources. Eclipse doesn't know this and warns anyway. That's why I suppressed it. I'll close it, if you like it better that way.

yegor256 · 2017-08-09T11:48:24Z

@semantosoph looks cool, thanks for your contribution! I made a few minor comments above

semantosoph · 2017-08-09T12:49:29Z

@yegor256 There you go, I made the requested changes.

I would appreciate it, if you could add me to the contributors list this time.

yegor256 · 2017-08-09T14:19:44Z

src/main/java/org/takes/facets/auth/PsToken.java

+            final String jwt = head.trim().split(" ", 2)[1].trim();
+            final byte[] jwtheader = jwt.split(dot)[0].getBytes();
+            final byte[] jwtpayload = jwt.split(dot)[1].getBytes();
+            final byte[] jwtsign = jwt.split(dot)[2].getBytes();


@semantosoph this code looks a bit weird. Why can't you do:

final String[] parts = jwt.split(dot); final byte[] jwtheader = parts[0].getBytes(); final byte[] jwtpayload = parts[1].getBytes(); final byte[] jwtsign = parts[2].getBytes();

yegor256 · 2017-08-09T14:22:00Z

src/main/java/org/takes/facets/auth/signatures/SiHmac.java

+     *  for all unexpected exceptions
+     */
+    private byte[] encrypt(final byte[] bytes) throws IOException {
+        final byte[] encrypted;


@semantosoph why do you need this variable? Can't you just do

return formatter.toString().getBytes();

Indeed, I can.

yegor256 · 2017-08-09T14:23:31Z

@semantosoph a few more comments above. Of course, we can add you to the list, but we don't have that list now :) Feel free to add it to README, just like it's done in github.com/yegor256/cactoos

semantosoph · 2017-08-09T14:39:31Z

@yegor256 Changes done. I'll compile the contributors list once I've got a little spare time.

yegor256 · 2017-08-09T15:59:06Z

@rultor merge

rultor · 2017-08-09T15:59:37Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-08-09T16:21:46Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

yegor256 · 2017-08-10T13:38:04Z

@semantosoph when you want me to release a new version, say it here, not in Twitter :)

yegor256 · 2017-08-10T13:38:22Z

@rultor release, tag is 1.6

rultor · 2017-08-10T13:38:34Z

@rultor release, tag is 1.6

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2017-08-10T13:59:14Z

@rultor release, tag is 1.6

@yegor256 Done! FYI, the full log is here (took me 20min)

0crat · 2017-08-14T22:14:58Z

Job gh:yegor256/takes#743 assigned to @caarlos0, please go ahead (policy).

0crat · 2017-11-14T16:29:38Z

@caarlos0 this job was assigned to you 8 days ago.
It will be taken away from you after 10 days from start (this is our policy).

0crat · 2017-11-16T19:16:26Z

Oops! Job gh:yegor256/takes#743 is not assigned to anyone.

0crat · 2017-11-16T19:17:34Z

Oops! Job gh:yegor256/takes#743 is not assigned to anyone.

0crat · 2017-11-16T19:18:35Z

Oops! Job gh:yegor256/takes#743 is not assigned to anyone.

semantosoph added 4 commits August 4, 2017 14:09

Introducing Signatures

8672438

Some clean up in PsToken and SiHmac.

dd5da5b

Fixes on the new Token.

aa2d096

Merge https://github.com/yegor256/takes into jwt-impl

3d19d36

Adding tests for Token

266bafa

yegor256 reviewed Aug 9, 2017

View reviewed changes

Improving code quality.

fb23f6a

yegor256 reviewed Aug 9, 2017

View reviewed changes

Some more cleaning

9448788

rultor merged commit 9448788 into yegor256:master Aug 9, 2017

semantosoph deleted the jwt-impl branch August 10, 2017 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of JSON Web Token #743

Implementation of JSON Web Token #743

semantosoph commented Aug 9, 2017 •

edited

Loading

0crat commented Aug 9, 2017

0crat commented Aug 9, 2017

0crat commented Aug 9, 2017

codecov-io commented Aug 9, 2017 •

edited

Loading

yegor256 Aug 9, 2017

semantosoph Aug 9, 2017

yegor256 Aug 9, 2017

semantosoph Aug 9, 2017

yegor256 Aug 9, 2017

semantosoph Aug 9, 2017

yegor256 commented Aug 9, 2017

semantosoph commented Aug 9, 2017

yegor256 Aug 9, 2017

semantosoph Aug 9, 2017

yegor256 Aug 9, 2017

semantosoph Aug 9, 2017

yegor256 commented Aug 9, 2017

semantosoph commented Aug 9, 2017

yegor256 commented Aug 9, 2017

rultor commented Aug 9, 2017

rultor commented Aug 9, 2017

yegor256 commented Aug 10, 2017

yegor256 commented Aug 10, 2017

rultor commented Aug 10, 2017

rultor commented Aug 10, 2017

0crat commented Aug 14, 2017

0crat commented Nov 14, 2017

0crat commented Nov 16, 2017

0crat commented Nov 16, 2017

0crat commented Nov 16, 2017

Implementation of JSON Web Token #743

Implementation of JSON Web Token #743

Conversation

semantosoph commented Aug 9, 2017 • edited Loading

0crat commented Aug 9, 2017

0crat commented Aug 9, 2017

0crat commented Aug 9, 2017

codecov-io commented Aug 9, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yegor256 commented Aug 9, 2017

semantosoph commented Aug 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yegor256 commented Aug 9, 2017

semantosoph commented Aug 9, 2017

yegor256 commented Aug 9, 2017

rultor commented Aug 9, 2017

rultor commented Aug 9, 2017

yegor256 commented Aug 10, 2017

yegor256 commented Aug 10, 2017

rultor commented Aug 10, 2017

rultor commented Aug 10, 2017

0crat commented Aug 14, 2017

0crat commented Nov 14, 2017

0crat commented Nov 16, 2017

0crat commented Nov 16, 2017

0crat commented Nov 16, 2017

semantosoph commented Aug 9, 2017 •

edited

Loading

codecov-io commented Aug 9, 2017 •

edited

Loading