RsPrint close stream

[jimkast]

Fixed #838 . RsPrint should close stream after printing it to an OutputStream.

[0crat]

Job #840 is now in scope, role is REV

[0crat]

This pull request #840 is assigned to @g4s8/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

[g4s8]

@jimkast thanks for contributing. But there are some code style and quality issues with this PR:

[INFO] Checkstyle: src/main/java/org/takes/rs/RsPrint.java[31]: Empty line or comment between imports is not allowed (ImportCohesionCheck)
[INFO] Checkstyle: src/main/java/org/takes/rs/RsPrint.java[32]: Using the '.*' form of import should be avoided - java.io.*. (AvoidStarImportCheck)
[INFO] Checkstyle: src/main/java/org/takes/rs/RsPrint.java[32]: Wrong order for 'java.io.*' import. (ImportOrderCheck)
[INFO] Checkstyle: src/test/java/org/takes/rs/RsPrintTest.java[30]: Empty line or comment between imports is not allowed (ImportCohesionCheck)
[INFO] Checkstyle: src/test/java/org/takes/rs/RsPrintTest.java[31]: Wrong order for 'java.io.ByteArrayInputStream' import. (ImportOrderCheck)
[INFO] Checkstyle: src/test/java/org/takes/rs/RsPrintTest.java[43]: Class Data Abstraction Coupling is 9 (max allowed is 7) classes [AtomicBoolean, ByteArrayInputStream, ByteArrayOutputStream, FailOutputStream, IOException, RsPrint, RsText, RsWithBody, RsWithHeader]. (ClassDataAbstractionCouplingCheck)
[INFO] Checkstyle: src/test/java/org/takes/rs/RsPrintTest.java[103]: Missing a Javadoc comment. (JavadocMethodCheck)
[INFO] Checkstyle: src/test/java/org/takes/rs/RsPrintTest.java[106]: Line is longer than 80 characters (found 88). (LineLengthCheck)
[INFO] Checkstyle: src/test/java/org/takes/rs/RsPrintTest.java[106]: Parameters should start on a new line (BracketsStructureCheck)

please fix them. To ensure that your changes pass quality checks run maven build with enabled qulice plugin:

mvn clean install -Pqulice

[0crat]

@g4s8/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[g4s8]

@jimkast this PR still failed to build, see https://travis-ci.org/yegor256/takes/builds/381567096?utm_source=github_status&utm_medium=notification logs or try to build it locally with

mvn clean install -Pqulice

[jimkast]

I removed the test which caused issues but still cannot overcome qulice code style checks.

[g4s8]

@jimkast You have checkstyle issue:

Checkstyle: src/main/java/org/takes/rs/RsPrint.java[31]: Wrong order for 'java.io.ByteArrayOutputStream' import. (ImportOrderCheck)

it means that in file src/main/java/org/takes/rs/RsPrint.java you have java imports in wrong order, checkstyle forces to use alphabetically import order.

[0crat]

The user @g4s8/z resigned from #840, please stop working. Reason for job resignation: It is older than 10 days, see §8

[0crat]

Resigned on delay, see §8: -15 point(s) just awarded to @g4s8/z

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@jimkast @yegor256 Oops, I failed. You can see the full log here (spent 9min)

++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 3035: running'
waiting for AppVeyor build 3035: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/3035
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 3035: running'
waiting for AppVeyor build 3035: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/3035
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 3035: running'
waiting for AppVeyor build 3035: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/3035
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 3035: running'
waiting for AppVeyor build 3035: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/3035
++ jq -r .build.status
+ status=running
+ '[' running == null ']'
+ '[' running == success ']'
+ '[' running == failed ']'
+ echo 'waiting for AppVeyor build 3035: running'
waiting for AppVeyor build 3035: running
+ sleep 5s
+ true
++ curl -K ../curl-appveyor.cfg https://ci.appveyor.com/api/projects/yegor256/takes/build/3035
++ jq -r .build.status
+ status=failed
+ '[' failed == null ']'
+ '[' failed == success ']'
+ '[' failed == failed ']'
+ echo 'see https://ci.appveyor.com/project/yegor256/takes/build/3035'
see https://ci.appveyor.com/project/yegor256/takes/build/3035
+ exit 1
container a38959a8d6af236672760b511897cca6f80467cf9f51d971df1f55376be20087 is dead
Mon Jun 11 23:01:36 CEST 2018

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

@yegor256/z everybody who has role REV is banned at #840; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[0crat]

Job gh:yegor256/takes#840 is not assigned, can't get performer

[0crat]

The job #840 is now out of scope