TkMethods now returns 405 on unsupported method #875
Conversation
|
Job #875 is now in scope, role is |
|
This pull request #875 is assigned to @krzyk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
|
@paulodamaso travis should be re-run because of #876, I don't have the access rights to do so. |
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
============================================
+ Coverage 75.3% 75.45% +0.15%
- Complexity 974 977 +3
============================================
Files 220 220
Lines 4717 4718 +1
Branches 368 368
============================================
+ Hits 3552 3560 +8
+ Misses 1010 1003 -7
Partials 155 155
Continue to review full report at Codecov.
|
|
@victornoel Done |
|
@paulodamaso thanks, it worked :) |
| @@ -62,4 +67,19 @@ public void throwsExceptionOnActinOnUnproperMethod() throws | |||
| new RqFake(RqMethod.GET) | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * TkMethods can return 405 status when acting on unknown method method. | |||
There was a problem hiding this comment.
@victornoel method method? :)
| IOException { | ||
| new FtRemote(new TkMethods(new TkEmpty(), "PUT")).exec( | ||
| url -> new JdkRequest(url) | ||
| .method("POST") |
| @Test | ||
| public void returnsMethodIsNotAllowedForUnsupportedMethods() throws | ||
| IOException { | ||
| new FtRemote(new TkMethods(new TkEmpty(), "PUT")).exec( |
|
|
||
| /** | ||
| * TkMethods can return 405 status when acting on unknown method method. | ||
| * @throws IOException if any I/O error occurs. |
There was a problem hiding this comment.
@victornoel descriptions in javadoc for throws/params/return should start with capital letter, and should not end with a dot.
victornoel
force-pushed
the
861-tkmethods-405
branch
from
a2b15ba to
e6fc4cf
Compare
|
@krzyk thanks, I've updated the commit and rebased on master |
|
@victornoel thanks |
|
@rultor merge |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 19min) |
|
@ypshenychka/z please review this job completed by @krzyk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
The job #875 is now out of scope |
|
Payment to |
|
@krzyk According to our QA Rules:
Only two major issues were found during code review. |
|
@ypshenychka I confirm |
|
@krzyk Thanks |
|
@0crat quality acceptable |
|
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
This is for #861.
Added a test and a fix.