Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#842 migrated to velocity 2.0 #891

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Conversation

olenagerasimova
Copy link
Contributor

For #842 I've migrated to velocity 2.0. For more details check #842.

@0crat
Copy link
Collaborator

0crat commented Dec 11, 2018

Job #891 is now in scope, role is REV

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #891 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     75.34%   75.48%   +0.13%     
- Complexity      976      981       +5     
============================================
  Files           220      220              
  Lines          4718     4724       +6     
  Branches        368      369       +1     
============================================
+ Hits           3555     3566      +11     
+ Misses         1006     1003       -3     
+ Partials        157      155       -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/takes/rs/RsVelocity.java 86.11% <100%> (+2.77%) 10 <3> (+3) ⬆️
...in/java/org/takes/facets/auth/codecs/CcSalted.java 86.84% <0%> (+13.15%) 11% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d43de3...f5faabb. Read the comment docs.

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Dec 12, 2018

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f5faabb into yegor256:master Dec 12, 2018
@rultor
Copy link
Collaborator

rultor commented Dec 12, 2018

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 21min)

@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

Job gh:yegor256/takes#891 is not assigned, can't get performer

@0crat 0crat removed the scope label Dec 12, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 12, 2018

The job #891 is now out of scope

@paulodamaso
Copy link
Contributor

@rultor release, tag is 1.12

@rultor
Copy link
Collaborator

rultor commented Dec 13, 2018

@rultor release, tag is 1.12

@paulodamaso OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Dec 13, 2018

@rultor release, tag is 1.12

@paulodamaso Done! FYI, the full log is here (took me 22min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants