-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For #925: Copyright update. #939
Conversation
Job #939 is now in scope, role is |
This pull request #939 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
============================================
+ Coverage 74.14% 74.16% +0.02%
- Complexity 971 972 +1
============================================
Files 222 222
Lines 4785 4785
Branches 361 361
============================================
+ Hits 3548 3549 +1
Misses 1086 1086
+ Partials 151 150 -1
Continue to review full report at Codecov.
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Oops, I failed. You can see the full log here (spent 3min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Oops, I failed. You can see the full log here (spent 4min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Oops, I failed. You can see the full log here (spent 3min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Oops, I failed. You can see the full log here (spent 3min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Oops, I failed. You can see the full log here (spent 4min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Oops, I failed. You can see the full log here (spent 18min)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 21min) |
@rultor release tag is |
@paulodamaso OK, I will release it now. Please check the progress here |
Job was finished in 2 hours, bonus for fast delivery is possible (see §36) |
@ypshenychka/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
The job #939 is now out of scope |
Payment to |
@paulodamaso Done! FYI, the full log is here (took me 21min) |
@fabriciofx According to our QA Rules:
No issues were found during code review. |
@ypshenychka I didn't any review, because @paulodamaso (ARC) has merged the PR directly. |
@fabriciofx I see. But still making sure you agree I can't pay you here since no work was done here by you. |
@ypshenychka Ok. Thanks! |
@fabriciofx thank you |
@0crat quality bad |
Quality is low, no payment, see §31 |
@ypshenychka The project doesn't have enough funds, can't make a payment |
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
For #925: Copyright update.