Add reproducer for #577 #947

Serranya · 2019-01-16T11:51:36Z

This adds a simplified testcase for the problem described in #577

A puzzle tracks the completion of the actual fix.

0crat · 2019-01-16T11:54:10Z

Job #947 is now in scope, role is REV

0crat · 2019-01-16T11:55:57Z

This pull request #947 is assigned to @fabriciofx /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

codecov-io · 2019-01-16T12:35:41Z

Codecov Report

Merging #947 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #947   +/-   ##
========================================
  Coverage      74.1%   74.1%           
  Complexity      971     971           
========================================
  Files           222     222           
  Lines          4785    4785           
  Branches        361     361           
========================================
  Hits           3546    3546           
  Misses         1089    1089           
  Partials        150     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e161aee...5b0a0bf. Read the comment docs.

fabriciofx

@Serranya Done. Please, check it.

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java

fabriciofx

@Serranya done. Check it.

src/test/java/org/takes/rq/multipart/ContentDispositionHeaderText.java

src/test/java/org/takes/rq/multipart/ContentLengthHeaderText.java

Serranya · 2019-01-16T20:31:13Z

@fabriciofx Please take another look.

fabriciofx

@Serranya done. Check it again. Thanks!

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java

Serranya · 2019-01-17T11:25:40Z

@fabriciofx Please review once more

fabriciofx · 2019-01-17T12:03:02Z

@Serranya I seems fine now. Thanks!

fabriciofx · 2019-01-17T12:03:14Z

@rultor merge

rultor · 2019-01-17T12:04:23Z

@rultor merge

@fabriciofx Thanks for your request. @paulodamaso Please confirm this.

paulodamaso

@Serranya Just a comment, please take a look

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java

Serranya · 2019-01-19T14:27:39Z

@paulodamaso @fabriciofx I updated the PR once more

fabriciofx · 2019-01-19T21:29:52Z

@paulodamaso Can you check what is wrong with Shippable? I think there is something wrong with Ruby installation...

fabriciofx · 2019-01-19T23:38:39Z

@Serranya it's ok to me. Thanks!

fabriciofx · 2019-01-19T23:38:45Z

@rultor merge

paulodamaso · 2019-01-19T23:38:48Z

@fabriciofx It seems that I've activated shippable for takes by mistake, let's ignore it

fabriciofx · 2019-01-19T23:39:14Z

@fabriciofx It seems that I've activated shippable for takes by mistake, let's ignore it

@paulodamaso ok! You can merge it now.

rultor · 2019-01-19T23:39:31Z

@rultor merge

@fabriciofx Thanks for your request. @paulodamaso Please confirm this.

paulodamaso · 2019-01-19T23:42:08Z

@rultor merge

rultor · 2019-01-19T23:43:10Z

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-20T00:01:47Z

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 18min)

0crat · 2019-01-20T00:28:57Z

@ypshenychka /z please review this job completed by @fabriciofx /z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat · 2019-01-20T00:31:30Z

The job #947 is now out of scope

0crat · 2019-01-20T00:54:25Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso /z

ypshenychka · 2019-01-20T07:23:00Z

@Serranya According to our QA Rules:

Messages in a job always start with a name of a user they are addressed to.

Please correct your messages here and here by indicating an addressee in the beginning.

Serranya · 2019-01-20T10:19:14Z

@ypshenychka I updated the messages.

ypshenychka · 2019-01-20T20:31:24Z

@Serranya thanks

ypshenychka · 2019-01-20T20:31:32Z

@0crat quality acceptable

0crat · 2019-01-20T20:40:46Z

@0crat quality acceptable (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

0crat · 2019-01-20T20:41:09Z

Order was finished, quality is "acceptable": +15 point(s) just awarded to @fabriciofx /z

0crat · 2019-01-20T20:41:12Z

Quality review completed: +8 point(s) just awarded to @ypshenychka /z

0crat added the scope label Jan 16, 2019

Serranya force-pushed the #577 branch from acc3b52 to 1f153f0 Compare January 16, 2019 12:28

fabriciofx reviewed Jan 16, 2019

View reviewed changes

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved

fabriciofx reviewed Jan 16, 2019

View reviewed changes

src/test/java/org/takes/rq/multipart/ContentDispositionHeaderText.java Outdated Show resolved Hide resolved

src/test/java/org/takes/rq/multipart/ContentLengthHeaderText.java Outdated Show resolved Hide resolved

Serranya force-pushed the #577 branch 3 times, most recently from 7cc6927 to 4a39ec1 Compare January 16, 2019 20:21

fabriciofx reviewed Jan 16, 2019

View reviewed changes

Serranya force-pushed the #577 branch from 4a39ec1 to c81c991 Compare January 17, 2019 08:45

paulodamaso suggested changes Jan 17, 2019

View reviewed changes

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Show resolved Hide resolved

Add reproducer for yegor256#577

5b0a0bf

Serranya force-pushed the #577 branch from c81c991 to 5b0a0bf Compare January 19, 2019 14:25

paulodamaso approved these changes Jan 19, 2019

View reviewed changes

rultor merged commit 5b0a0bf into yegor256:master Jan 20, 2019

0crat removed the scope label Jan 20, 2019

Serranya deleted the #577 branch January 20, 2019 10:15

Serranya mentioned this pull request Jan 20, 2019

RqMultiPart.Fake fails on more then one part #577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reproducer for #577 #947

Add reproducer for #577 #947

Serranya commented Jan 16, 2019

0crat commented Jan 16, 2019

0crat commented Jan 16, 2019

codecov-io commented Jan 16, 2019 •

edited

Loading

fabriciofx left a comment

fabriciofx left a comment

Serranya commented Jan 16, 2019

fabriciofx left a comment

Serranya commented Jan 17, 2019

fabriciofx commented Jan 17, 2019

fabriciofx commented Jan 17, 2019

rultor commented Jan 17, 2019

paulodamaso left a comment

Serranya commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

paulodamaso commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

rultor commented Jan 19, 2019

paulodamaso commented Jan 19, 2019

rultor commented Jan 19, 2019

rultor commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

ypshenychka commented Jan 20, 2019

Serranya commented Jan 20, 2019

ypshenychka commented Jan 20, 2019

ypshenychka commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

Add reproducer for #577 #947

Add reproducer for #577 #947

Conversation

Serranya commented Jan 16, 2019

0crat commented Jan 16, 2019

0crat commented Jan 16, 2019

codecov-io commented Jan 16, 2019 • edited Loading

Codecov Report

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx left a comment

Choose a reason for hiding this comment

Serranya commented Jan 16, 2019

fabriciofx left a comment

Choose a reason for hiding this comment

Serranya commented Jan 17, 2019

fabriciofx commented Jan 17, 2019

fabriciofx commented Jan 17, 2019

rultor commented Jan 17, 2019

paulodamaso left a comment

Choose a reason for hiding this comment

Serranya commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

paulodamaso commented Jan 19, 2019

fabriciofx commented Jan 19, 2019

rultor commented Jan 19, 2019

paulodamaso commented Jan 19, 2019

rultor commented Jan 19, 2019

rultor commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

ypshenychka commented Jan 20, 2019

Serranya commented Jan 20, 2019

ypshenychka commented Jan 20, 2019

ypshenychka commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

0crat commented Jan 20, 2019

codecov-io commented Jan 16, 2019 •

edited

Loading