-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project report - 2019-01-26. #956
Conversation
Job #956 is now in scope, role is |
@0crat out |
@paulodamaso Job |
@paulodamaso @fabriciofx/z resigned from #956, since the job is not in scope anymore |
@paulodamaso The job #956 is now out of scope |
This pull request #956 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
============================================
+ Coverage 72.29% 72.31% +0.02%
- Complexity 971 972 +1
============================================
Files 224 224
Lines 4905 4905
Branches 364 364
============================================
+ Hits 3546 3547 +1
Misses 1209 1209
+ Partials 150 149 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso Done. Please, check out.
status-reports/2019-01-26.md
Outdated
* Replace Guava with Cactoos [60%] (30 class dependencies left) | ||
* Null removal [50%] (44 matches left) | ||
|
||
Issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso Please, remove the ":".
developers most of them are not working for free, so they did not receive tasks | ||
|
||
Risks | ||
* Cactoos may not provide all features to fully replace Guava [1/7] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso cactoos-http
overleap takes
funcionalities isn't a risk too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriciofx I don't think so; it would be a risk if we decided to use, since it could not provide all funcionality we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulodamaso Right, but in the future they can overleap their functionalities... it shouldn't be considered in any time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriciofx Yes, in the future we will have this
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 22min) |
Job |
This job is not in scope |
@rultor release tag is |
@paulodamaso OK, I will release it now. Please check the progress here |
@paulodamaso Done! FYI, the full log is here (took me 14min) |
Project report - 2019-01-26.