Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project report - 2019-01-26. #956

Merged
merged 3 commits into from
Jan 26, 2019
Merged

Project report - 2019-01-26. #956

merged 3 commits into from
Jan 26, 2019

Conversation

paulodamaso
Copy link
Contributor

Project report - 2019-01-26.

@0crat 0crat added the scope label Jan 26, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

Job #956 is now in scope, role is REV

@paulodamaso paulodamaso removed the scope label Jan 26, 2019
@paulodamaso
Copy link
Contributor Author

@0crat out

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

@0crat out (here)

@paulodamaso Job gh:yegor256/takes#956 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

@0crat out (here)

@paulodamaso @fabriciofx/z resigned from #956, since the job is not in scope anymore

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

@0crat out (here)

@paulodamaso The job #956 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

This pull request #956 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #956 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #956      +/-   ##
============================================
+ Coverage     72.29%   72.31%   +0.02%     
- Complexity      971      972       +1     
============================================
  Files           224      224              
  Lines          4905     4905              
  Branches        364      364              
============================================
+ Hits           3546     3547       +1     
  Misses         1209     1209              
+ Partials        150      149       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/takes/http/MainRemote.java 55.73% <0%> (+1.63%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a6af3...3fb3ff7. Read the comment docs.

Copy link
Contributor

@fabriciofx fabriciofx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso Done. Please, check out.

* Replace Guava with Cactoos [60%] (30 class dependencies left)
* Null removal [50%] (44 matches left)

Issues:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso Please, remove the ":".

developers most of them are not working for free, so they did not receive tasks

Risks
* Cactoos may not provide all features to fully replace Guava [1/7]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso cactoos-http overleap takes funcionalities isn't a risk too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriciofx I don't think so; it would be a risk if we decided to use, since it could not provide all funcionality we need.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulodamaso Right, but in the future they can overleap their functionalities... it shouldn't be considered in any time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriciofx Yes, in the future we will have this

@paulodamaso
Copy link
Contributor Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 26, 2019

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3fb3ff7 into yegor256:master Jan 26, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 26, 2019

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 22min)

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

Job gh:yegor256/takes#956 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 26, 2019

This job is not in scope

@paulodamaso
Copy link
Contributor Author

@rultor release tag is 1.16

@rultor
Copy link
Collaborator

rultor commented Jan 26, 2019

@rultor release tag is 1.16

@paulodamaso OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jan 26, 2019

@rultor release tag is 1.16

@paulodamaso Done! FYI, the full log is here (took me 14min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants