Finishing experimental Gulp implementation #837
Conversation
| var cb = this.async(); | ||
|
|
||
| this.prompt([{ | ||
| type: 'confirm', | ||
| name: 'bootstrap', | ||
| message: 'Would you like to include Bootstrap?', | ||
| message: 'Would you like to include Twitter Bootstrap?', |
|
I updated both Bootstrap mentions. Sorry for overlooking those. |
hermansje
force-pushed
the
master
branch
2 times, most recently
from
1f40520 to
776d125
Compare
|
I rebased my pull request and tried to follow the guidelines. |
|
What does this add over #672? That pr wasn't waiting for a cleanup, it was waiting for a major new release. |
|
It doesn't add new features. |
|
|
|
Any news on this? |
hermansje
force-pushed
the
master
branch
2 times, most recently
from
adecaf0 to
cd420f7
Compare
|
I'd like to see this get merged in as well. The most popular angular generator should probably support the two most popular build systems. I don't feel it necessary to break this into two projects as we can cleanly encapsulate the build logic without creating a maintainability headache. |
|
Honestly, at this point I'd even say it makes sense to drop Grunt in favor of Gulp. I don't see any reason not to. Also makes it way easier to maintain. I wonder what @eddiemonge thinks. |
|
👍 |
|
I still like Grunt. I would prefer to see Grunt as the default and Gulp as an advanced option (not a prompt). I'd also want to make sure all the tools that are used for angular (some that aren't in here yet that I use daily) are supported in both first. |
|
can you rebase and resolve the conflicts please? |
add an option to use Gulp instead of Grunt Closes yeoman#672 (+1 squashed commits) Squashed commits: [87a7e7c] feat(gen): add support for Gulp Add an option to use Gulp instead of Grunt
|
I solved the conflicts and rebased the pull request. |
| }.bind(this)); | ||
| }; | ||
|
|
||
| Generator.prototype.askForStyles = function askForStyles() { |
There was a problem hiding this comment.
this shouldnt be a part of this PR
Finishing experimental Gulp implementation
I solved the merge conflicts of pending pull request #672 and meanwhile updated some gulp dependencies (clean -> rimraf, ngmin -> ngAnnotate) and adjusted the code to the changed file structure.