This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 150
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Make gulp deal with external bower components dir
- Loading branch information
Showing
5 changed files
with
132 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,11 @@ | ||
<link rel="import" href="../bower_components/core-drawer-panel/core-drawer-panel.html"> | ||
<link rel="import" href="../bower_components/core-header-panel/core-header-panel.html"> | ||
<link rel="import" href="../bower_components/core-toolbar/core-toolbar.html"> | ||
<link rel="import" href="../bower_components/core-icons/core-icons.html"> | ||
<link rel="import" href="../bower_components/paper-icon-button/paper-icon-button.html"> | ||
<link rel="import" href="../bower_components/core-menu/core-menu.html"> | ||
<link rel="import" href="../bower_components/core-item/core-item.html"> | ||
<link rel="import" href="yo-list/yo-list.html"> | ||
<link rel="import" href="yo-greeting/yo-greeting.html"> | ||
|
||
<!-- Add your elements here --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,69 @@ | ||
<!doctype html> | ||
<html lang=""> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta name="description" content=""> | ||
<meta name="viewport" content="width=device-width, initial-scale=1"> | ||
<title><%= appname %></title> | ||
<!-- Place favicon.ico and apple-touch-icon.png in the root directory --> | ||
|
||
<!-- build:css styles/main.css --> | ||
<link rel="stylesheet" href="styles/main.css"> | ||
<!-- endbuild--> | ||
|
||
<!-- build:js bower_components/webcomponentsjs/webcomponents.min.js --> | ||
<script src="bower_components/webcomponentsjs/webcomponents.js"></script> | ||
<!-- endbuild --> | ||
|
||
<!-- will be replaced with elements/elements.vulcanized.html --> | ||
<link rel="import" href="elements/elements.html"> | ||
<!-- endreplace--> | ||
</head> | ||
<body unresolved> | ||
<div class="hero-unit"> | ||
<yo-greeting></yo-greeting> | ||
<p>You now have</p> | ||
<yo-list></yo-list> | ||
</div> | ||
|
||
<!-- build:js scripts/app.js --> | ||
<script src="scripts/app.js"></script> | ||
<!-- endbuild--> | ||
</body> | ||
|
||
<head> | ||
<meta charset="utf-8"> | ||
<meta name="description" content=""> | ||
<meta name="viewport" content="width=device-width, initial-scale=1"> | ||
<title>poly foo</title> | ||
<!-- Place favicon.ico and apple-touch-icon.png in the root directory --> | ||
|
||
<!-- build:css styles/main.css --> | ||
<link rel="stylesheet" href="styles/main.css"> | ||
<!-- endbuild--> | ||
|
||
<!-- build:js bower_components/webcomponentsjs/webcomponents.min.js --> | ||
<script src="bower_components/webcomponentsjs/webcomponents.js"></script> | ||
<!-- endbuild --> | ||
|
||
<!-- will be replaced with elements/elements.vulcanized.html --> | ||
<link rel="import" href="elements/elements.html"> | ||
<!-- endreplace--> | ||
</head> | ||
|
||
<body unresolved fullbleed layout vertical> | ||
<template is="auto-binding" id="app"> | ||
|
||
<core-drawer-panel> | ||
|
||
<!-- Drawer --> | ||
<core-header-panel drawer> | ||
|
||
<!-- Drawer Toolbar --> | ||
<core-toolbar>Menu</core-toolbar> | ||
|
||
<!-- Drawer Content --> | ||
<core-menu selected="0"> | ||
<core-item label="Yo"></core-item> | ||
<core-item label="Polymer"></core-item> | ||
<core-item label="App"></core-item> | ||
</core-menu> | ||
|
||
</core-header-panel> | ||
|
||
<!-- Main --> | ||
<core-header-panel main> | ||
|
||
<!-- Main Toolbar --> | ||
<core-toolbar> | ||
<paper-icon-button icon="menu" core-drawer-toggle></paper-icon-button> | ||
<span>{{appName}}</span> | ||
</core-toolbar> | ||
|
||
<!-- Main Content --> | ||
<div class="hero-unit"> | ||
<yo-greeting></yo-greeting> | ||
<p>You now have</p> | ||
<yo-list></yo-list> | ||
</div> | ||
</core-header-panel> | ||
</core-drawer-panel> | ||
|
||
</template> | ||
|
||
<!-- build:js scripts/app.js --> | ||
<script src="scripts/app.js"></script> | ||
<!-- endbuild--> | ||
</body> | ||
|
||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afcda33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robdodson The indentation you introduced in here is inconsistent with some other html files (I'm talking about not indenting inside of the
<html>
)In other official generators we don't do it this way as well.
afcda33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arthurvr is there a recommended indentation guide you can link me to?
afcda33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robdodson nope, I was just pointing out that every official generator I know about does it in another way, and that it's even inconsistent with some html files in this generator itself.