Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to Ruby Sass and add sourcemaps #272

Closed
wants to merge 1 commit into from
Closed

Revert to Ruby Sass and add sourcemaps #272

wants to merge 1 commit into from

Conversation

silvenon
Copy link
Member

@silvenon silvenon commented Feb 9, 2015

Sourcemaps will be generated without Sass as well, for PostCSS.

Fixes #256.

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

Oh, I forgot to add. I'm reverting to Ruby Sass because I don't know when libsass 3.2 will be released and I want something stable.

@sindresorhus
Copy link
Member

👎

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

Why? I really like it.

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

Not sure why tests fail, they ran successfully locally.

@sindresorhus
Copy link
Member

I don't see why we would want to revert back to ruby sass again. Source maps are useful, but not that important. I'd rather have speed.

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

I'd rather have merged @media queries. While nested @media queries are valid CSS3, nobody seems to use or talk about them much and they don't appear to work in IE11 (and maybe in other browsers which otherwise support @media queries). http://codepen.io/silvenon/pen/JoOxWb

I reverted simply because I wouldn't use this myself in the current state and I want to make a stable release. I'm planning to add libsass back as soon as I'm happy with it.

@sindresorhus
Copy link
Member

It's up to you. Feel free to merge if you think it's the best.

I just don't care about IE.

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

I only care about IE10+ and I think that's as far as we should assume for our users.

Ok, I'll fix the tests and merge.

@addyosmani
Copy link
Member

I'm +1 for speed over source maps on this one. I can only imagine the majority of devs would feel the same, but perhaps consider asking folks if they'd prefer one over the other before landing? The differences during watch are particularly large.

@mattycraig
Copy link

+1 for speed for sure.

@austinpray
Copy link

FYI: node-sass is currently broken on 0.12. Also for the past couple months it intermittently fails to build on linux.

The instability is a drag, but I would have a hard time going back to ruby sass. I'm hoping I can spend some time this week to help the node-sass guys get 2.0 out the door.

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

Speed > support for any IE at all? About 17% of web traffic?

@austinpray
Copy link

Not supporting latest IE is some silly stuff.

@thasmo
Copy link

thasmo commented Feb 9, 2015

+1 libsass

@arthurvr
Copy link
Member

arthurvr commented Feb 9, 2015

I must say I'm against dropping libsass too.

@mu7amad
Copy link

mu7amad commented Feb 9, 2015

+1 libsass

@dbashford
Copy link

Largely unfamiliar with Yeoman, so sorry if I'm out in left field, but isn't this something you can ask the user during scaffold? Probably a goodly amount of rework to make that happen, but if folks are evenly split, if its possible... a worthwhile effort?

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

@dbashford I think libsass is too close to being stable for this extra work to be worth it, but I can do it if more people would like this feature.

@silvenon
Copy link
Member Author

silvenon commented Feb 9, 2015

Ok, everyone seems to be against temporarily dropping libsass, so I'm closing this in favor of #274, because I mainly wanted source maps anyway.

@silvenon silvenon closed this Feb 9, 2015
@silvenon silvenon deleted the sass branch February 9, 2015 19:34
SBoudrias pushed a commit that referenced this pull request Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass sourcemap
9 participants