Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all dependencies #234

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Update all dependencies #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e163f9
Update all dependencies
fregante Jul 12, 2024
dad8bea
Undo AVA update
fregante Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,21 @@
"configstore": "^6.0.0",
"import-lazy": "^4.0.0",
"is-in-ci": "^0.1.0",
"is-installed-globally": "^0.4.0",
"is-installed-globally": "^1.0.0",
"is-npm": "^6.0.0",
"latest-version": "^7.0.0",
"latest-version": "^9.0.0",
"pupa": "^3.1.0",
"semver": "^7.5.4",
"semver": "^7.6.2",
"semver-diff": "^4.0.0",
"xdg-basedir": "^5.1.0"
},
"devDependencies": {
"ava": "^5.3.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AVA was not updated because:

test/update-notifier.js:28

   27:   setTimeout(() => {               
   28:     fs.unlinkSync(configstorePath);
   29:   }, 10_000);                      

  Error: ENOENT: no such file or directory, unlink '/home/runner/.config/configstore/update-notifier-update-notifier-tester.json'

  › Timeout._onTimeout (file://test/update-notifier.js:28:6)

  ✘ test/update-notifier.js exited with a non-zero exit code: 1

It can be updated separately

"clear-module": "^4.1.2",
"esmock": "^2.5.8",
"esmock": "^2.6.6",
"fixture-stdout": "^0.2.1",
"strip-ansi": "^7.1.0",
"xo": "^0.56.0"
"xo": "^0.58.0"
},
"ava": {
"timeout": "20s",
Expand Down
4 changes: 2 additions & 2 deletions update-notifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export default class UpdateNotifier {

constructor(options = {}) {
this.#options = options;
options.pkg = options.pkg ?? {};
options.distTag = options.distTag ?? 'latest';
options.pkg ??= {};
options.distTag ??= 'latest';

// Reduce pkg to the essential keys. with fallback to deprecated options
// TODO: Remove deprecated options at some point far into the future
Expand Down