Skip to content

Issue: Types not found. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
terkelg opened this issue Oct 1, 2023 · 1 comment · Fixed by #26
Closed

Issue: Types not found. #25

terkelg opened this issue Oct 1, 2023 · 1 comment · Fixed by #26
Labels
bug Something isn't working

Comments

@terkelg
Copy link

terkelg commented Oct 1, 2023 •
edited
Loading

When importing the library in TypeScript, the type declaration isn't found.
I think this issue is caused by package.json not linking to the correct file. It's pointing to a types file in the root of the build folder, but the NPM modules doesn't come bundled with that file.

It's also worth noting that the types for ESM and CJS are identical. You can remove the types from the export fields and point to a shared types file in types. VSCode cannot read the types inside export anyway.

CleanShot 2023-09-30 at 21 58 05@2x
@yeonjuan yeonjuan added the bug Something isn't working label Oct 1, 2023
@yeonjuan yeonjuan mentioned this issue Oct 1, 2023
Merged
@yeonjuan
Copy link
Owner

yeonjuan commented Oct 1, 2023

@terkelg Thanks for the report! The fixed version 0.0.14 published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: types not found issue yeonjuan/parse-git-diff
2 participants
@terkelg @yeonjuan