Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app should not ask for Storage permission when selecting internal storage #461

Closed
awefartib opened this issue May 23, 2018 · 0 comments
Closed

app should not ask for Storage permission when selecting internal storage #461

awefartib opened this issue May 23, 2018 · 0 comments
Milestone
0.42

Comments

@awefartib
Copy link

Expected behaviour

Yalp Store should not ask for Storage permission when Internal Storage is selected in options

Actual behaviour

Even when Internal Storage is selected for apk downloads, Yalp Store still asks for Storage permission and refuses to download the apk without it

Steps to reproduce

  1. don't grant storage permission
  2. choose internal storage in app settings
  3. download app

Info about your device

Pixel 2
@yeriomin yeriomin added this to the 0.42 milestone May 23, 2018
yeriomin added a commit that referenced this issue May 23, 2018
@yeriomin
Issue #461 WRITE_EXTERNAL_STORAGE permission is no longer requested i…
88a896d 
…f internal storage is chosen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.42
Development

No branches or pull requests
2 participants
@yeriomin @awefartib