Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the 1207 fix to persistent-2.11.0 #1209

Merged
merged 7 commits into from
Mar 17, 2021

Conversation

parsonsmatt
Copy link
Collaborator

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@codygman
Copy link
Contributor

codygman commented Mar 17, 2021

Alright using:

  - git: https://github.com/yesodweb/persistent
    commit: f496bbdd74f8b26be1d09dd0bfcc697bd7d8d48b
    subdirs:
     - persistent
     - persistent-mongoDB
     - persistent-postgresql
     - persistent-template

It passed:

  • 1 2 times from clean slate in CI
  • 10 times in ghcid

I'll keep running it in CI which starts from a clean slate and see what happens.

@parsonsmatt
Copy link
Collaborator Author

The problem occurred when running against the single threaded runtime as well as the threaded runtime, and only was alleviated by having more and more threads available (eg -N2 had more errors than -N4 etc). Not sure if ghcid would exacerbate or ameliorate the issue.

Here's hoping for those good CI passes 😄

@parsonsmatt parsonsmatt merged commit e7a7842 into persistent-2.11.0 Mar 17, 2021
@parsonsmatt parsonsmatt deleted the matt/1199-fix-2-11-0 branch April 1, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants