Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it build with ghc 9.10 #1536

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Make it build with ghc 9.10 #1536

merged 2 commits into from
Jul 19, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented May 26, 2024

This still contains an allow-newer stanze that should be remove before this PR can be merged.

There are also quite a lot of compiler warnings that should be fixed at some time.

@parsonsmatt
Copy link
Collaborator

Are there links to upstream PRs for the allow-newer? Or are they just Hackage revisions waiting?

@erikd
Copy link
Contributor Author

erikd commented Jul 8, 2024

Are there links to upstream PRs for the allow-newer? Or are they just Hackage revisions waiting?

I have raised issues for both (the maintainer prefers issues to PRs). They have been waiting on a cabal release.

haskellari/postgresql-libpq#60
haskellari/postgresql-simple#139

@erikd
Copy link
Contributor Author

erikd commented Jul 10, 2024

Removed the allow-newer stanzas that I added. Ready to go IMO.

@erikd erikd marked this pull request as ready for review July 10, 2024 03:21
@erikd
Copy link
Contributor Author

erikd commented Jul 10, 2024

There are some compiler warnings.

@erikd erikd force-pushed the master branch 2 times, most recently from 963cc90 to 05f719a Compare July 17, 2024 03:31
@erikd erikd force-pushed the master branch 2 times, most recently from d3fe437 to 36b14bd Compare July 18, 2024 23:25
@parsonsmatt
Copy link
Collaborator

This is great, thanks! I'll make a point release for the affected packages.

@parsonsmatt parsonsmatt merged commit 201a1b9 into yesodweb:master Jul 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants