Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing NoManager #1017

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

kazu-yamamoto
Copy link
Contributor

"initialize" with non positive integer creates "NoManager".

@edsko What do you think?

@edsko
Copy link
Contributor

edsko commented Dec 17, 2024

I'll give this a shot and let you know :)

edsko added a commit to well-typed/grapesy that referenced this pull request Dec 17, 2024
edsko added a commit to well-typed/grapesy that referenced this pull request Dec 17, 2024
@edsko
Copy link
Contributor

edsko commented Dec 17, 2024

@kazu-yamamoto Looks good to me, and I ran the grapesy test-suite with this, using 0 instead of the previous workaround of maxBound, and it seems to be working perfectly (tested memory behaviour too, just in case). Thanks!

"initialize" with non positive integer creates "NoManager".
@kazu-yamamoto kazu-yamamoto merged commit 09d4e41 into yesodweb:master Dec 18, 2024
13 of 14 checks passed
@kazu-yamamoto kazu-yamamoto deleted the no-time-manager branch December 18, 2024 04:17
@kazu-yamamoto
Copy link
Contributor Author

Thanks.
A new version has been released.

edsko added a commit to well-typed/grapesy that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants