Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries update #97

Merged
merged 17 commits into from
Jun 30, 2023
Merged

Timeseries update #97

merged 17 commits into from
Jun 30, 2023

Conversation

kelvinqian00
Copy link
Contributor

@kelvinqian00 kelvinqian00 commented Jun 22, 2023

Update and remove functions in the timeseries namespace:

  • Remove all functions with the exception of arma-seq and time-seqs for being unused
  • Fix a bug in arma-seq where only the t-1 result and epsilon value were used in the computation of the t-th result, instead of all t-i results (where (<= 0 i (count phi)) for the result value and (<= 0 i (count theta)) for epsilon)
  • Change time-seqs keywords to be more descriptive, e.g. :sample-n to :sample-ns, :mod-seq to :minute-of-day-seq, etc
  • Change :day-night-seq to :minute-day-night-seq and add :hour-day-night-seq
  • Perform refactorings to arma-seq and time-seqs function by simplifying expressions and extracting helper functions
  • Add specs to time-seqs function
  • Add timeseries-test namespace for timeseries tests
  • Bring in same-ish library for floating point comparison tests
  • Create dev/series namespace, move comments there, and add timestamp histogram

Comment on lines +10 to +11
(set! *print-length* 10) ; unfortunately with-redefs does not always work
(with-redefs [*print-length* 10] ; prevent printing entire infinite seqs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually would like to know what I'm doing wrong here

(double
(maths/min-max 0.0 (/ (- a b) 2) 1.0)))
[bob-arma mask])
bob-prob (map (fn [a b]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad bob-prob is still in here lol

@kelvinqian00 kelvinqian00 requested a review from milt June 26, 2023 14:32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf do you have against bob

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't remove Bob, I just gave him a new home in dev/series

Base automatically changed from profile-gen-update to refactoring June 30, 2023 15:09
@kelvinqian00 kelvinqian00 merged commit 3acc9c8 into refactoring Jun 30, 2023
@kelvinqian00 kelvinqian00 deleted the timeseries-update branch June 30, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants