-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contract): add amount_of_proofs in TaskCreated event #1774
feat(contract): add amount_of_proofs in TaskCreated event #1774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to v2 here ?
I think it is useless to add V2. I will remove it |
chore: update ABIs in explorer and sdk chore: update anvil state
I made the following changes
Note: This PR requires redeploy the explorer after upgrading the contract |
…f_proofs-in-taskcreated-event
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Add amountOfProofs to TaskCreated event in BatcherPaymentService
Description
Caution
This upgrade requires a redeploy of the explorer because the ABI changes. Without redploying the explorer, it won't be able to get the feePerProof values for created batches
This feature may be of help in the future, but at the same time I wouldn't upgrade this contract for only this fix. It may be an acceptable PR if it is redeployed with another BatcherPayments upgrade.
Type of change
Please delete options that are not relevant.
Checklist
testnet
, everything else tostaging