Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mina verifiers #506

Draft
wants to merge 302 commits into
base: staging
Choose a base branch
from
Draft

Mina verifiers #506

wants to merge 302 commits into from

Conversation

gabrielbosio
Copy link
Collaborator

@gabrielbosio gabrielbosio commented Jun 26, 2024 •
edited
Loading

Mina verifiers

Implements Mina State verifier and Mina Account inclusion verifier.

Components

  • Mina State verifier: Runs a Pickles verification of a Mina State proof and checks that the Mina State is from a chain that was agreed by the network as safe. This proof can be fetched from Mina Devnet (link to Docker image) or from Mina Mainnet (link to Docker image).
  • Mina Account Inclusion verifier: Runs a Merkle proof verification to check that a Mina account is present in the Mina Ledger.

Details

  • Changes Go workflow runner to use Aligned runner because of memory limitations when adding Mina jobs.
  • Adds Make commands to send Mina test proofs and build and test Mina FFIs.
    • Documents in the guide how to send Mina test proofs.
  • Logs gas used in Aggregator and Mina verifiers.
  • Patches Arkworks in Batcher so that it uses OpenMina's fork.
  • Implements Mina State verifier and Mina Account inclusion verifier.
  • Adds Mina and MinaAccount to ProvingSystemId enum.

xqft and others added 30 commits July 11, 2024 17:54
@xqft
Make verifier index static
17adba3
@xqft
Fix mina operator lib name
9f4efd9
@xqft
Ignore dylib
b661ebb
@xqft
Replace mina/ gitignore with mina/lib one
ca12b7c
@xqft
Merge pull request #6 from lambdaclass/integrate_mina_operator
a067f65 
Integrate mina operator
@gabrielbosio
[WIP] Start adding consensus check
fc086d2
@gabrielbosio
Add consensus state deserialization
5842dd3
@gabrielbosio
Revert serde version changes
f678a1b
@xqft
WIP Deserialize blokchain vk json
95e702c
@xqft
Finish verifier index deserialization
9f402f7
@xqft
Fix hex decoding
238865f
@xqft
Add mainnet vk json, use it for the proof, fix warnings
e16d831
@xqft
Add mainnet proof
e1bc25c
@gabrielbosio
Merge pull request #9 from lambdaclass/mainnet_adaptation
61d2790 
Verify Mainnet pickles proofs
@gabrielbosio
Simplify consensus check to select only longer chain
737def5
@gabrielbosio
Merge branch 'mina' into consensus and test
2ed451a
@xqft
Add new query and parse script
c2e4518
@gabrielbosio
Use Devnet index from openmina
ca48b1d
@gabrielbosio
Use JSON file for index
d60ced5
@xqft
Merge pull request #13 from lambdaclass/devnet_index
f9e73a4 
Use Devnet verifier index
@xqft
Merge branch 'mina' into new_public_inputs
be2751b
@xqft
Query from new Devnet node
d11ed56
@xqft
Take state hash as field
d267b68
@xqft
Verify newly serialized protocol state and proof
2e2d0f3
@xqft
Remove dbg prints
4764eb7
@xqft
Tidy up code
b598231
@xqft
Add message errors
95f7dd7
@xqft
Add consensus checks todo
f4cc3fb
@gabrielbosio
Merge pull request #11 from lambdaclass/new_public_inputs
65ace03 
Add new serialized protocol state as public inputs
@gabrielbosio
Merge branch 'mina' into consensus
c4afc9e
@gabrielbosio gabrielbosio marked this pull request as ready for review October 8, 2024 20:43
@Oppen
Copy link
Collaborator

Oppen commented Oct 31, 2024

Converted to draft due to not being a priority for mainnet

@Oppen Oppen marked this pull request as draft October 31, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielbosio @Oppen @xqft @MauroToscano