Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the DFIQ import to import from local system as well #1018

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Refactor the DFIQ import to import from local system as well #1018

merged 9 commits into from
Feb 13, 2024

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Feb 12, 2024

No description provided.

@tomchop tomchop requested review from udgover and sebdraven February 12, 2024 18:57
udgover
udgover reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, otherwise LGTM!

plugins/feeds/public/dfiq.py Show resolved Hide resolved
core/schemas/dfiq.py Show resolved Hide resolved
@tomchop tomchop merged commit 4ead899 into main Feb 13, 2024
2 checks passed
@tomchop tomchop deleted the dfiq-improved branch February 13, 2024 14:53
@tomchop tomchop added code health Changes about syntax, code health, etc. and removed enhancement labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udgover udgover udgover left review comments

@sebdraven sebdraven Awaiting requested review from sebdraven

Assignees
No one assigned
Labels
code health Changes about syntax, code health, etc. tasks:feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchop @udgover