Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce search aliases (fixes #1001) #1021

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Introduce search aliases (fixes #1001) #1021

merged 7 commits into from
Feb 23, 2024

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Feb 19, 2024 •
edited
Loading

This PR introduces search aliases. The API can now be provided extra fields to also check for regex matches (useful when e.g. filtering for name but also alias in Malware entities)

Missing:

  • Tests

@tomchop tomchop mentioned this pull request Feb 19, 2024
Merged
1 task
sebdraven
sebdraven reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@sebdraven sebdraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test for alias !

@tomchop tomchop changed the title Introduce search aliases Introduce search aliases (fixes #1001) Feb 21, 2024
@tomchop tomchop mentioned this pull request Feb 21, 2024
Merged
sebdraven
sebdraven approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@sebdraven sebdraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sebdraven sebdraven merged commit 504e0fe into main Feb 23, 2024
2 checks passed
@sebdraven sebdraven deleted the searchalias branch February 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdraven sebdraven sebdraven approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchop @sebdraven