Add support for SSL JA3 signatures + feed #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchop
requested changes
Apr 30, 2024
Comment on lines
+53
to
+54
| if threat: | ||
| ja3_obs.tag([threat]) |
There was a problem hiding this comment.
I see that one of the lines has something like
7a29c223fb122ec64d10f0a159e07996,2019-06-09 22:55:29,2020-10-27 09:50:26,None
Will threat here be None in this case? or the STRING None? If it's the latter, then this will tag the observable with None which is not desireable.
There was a problem hiding this comment.
Pandas changes None to None python , I've done the test :)
Co-authored-by: Thomas Chopitea <tomchop@gmail.com>
Co-authored-by: Thomas Chopitea <tomchop@gmail.com>
tomchop
approved these changes
Apr 30, 2024
tomchop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1064