Event queue watcher and reducer #1162
Merged
+126
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves redis stability when there's no events / logs consumers running. As a matter of fact, when there's no consumers running, redis queue lists are growing infinitely and leads to OOM kill of the service.
To fix this issue, a watchdog has been added for each queue lists. It checks the length of the lists and trims them if greater than a configured value. The list will keep at least the most recent events based on the following configuration:
yeti.conf.sampledefinesevents.max_queue_sizeto 30000.This PR also removes
publish_logcall frompublish_eventmethod.