Switch I/O bound path operation functions to non-async #1166
+76
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves web api performance issues by removing async usage on I/O bound (ArangoDB calls) path operation functions. Since backend does not support async calls, web api was not running concurrently. Switching to non-async definitions lets FastAPI run calls in awaited thread pool as explained in documentation:
Regarding technical details, this is how FastAPI handles concurrency with non-async path operation functions:
Some path operation functions are still async because: