Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

1/8 Create lifecycle page and review component introduction #82

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rlasjunies
Copy link

this is the 1st PR of several (should be 8)

@jstarry I did not, yet, review the content providing more interesting component. I will do it after the split of the PR

@rlasjunies
Copy link
Author

@jstarry
I've replaced SimpleComponent by a ExampleComponent in the "main page" of Components

I am not so convinced ... I feel it heavy to read ... I still prefer the 1st proposal ;-p
I let you review the PRs ...

@rlasjunies
Copy link
Author

@jstarry @teymour-aldridge
Guys, as there is a lot of changes, it is complicate to review/follow.
To help, I am temporarly publishing the doc here

Doing so, you could see what it looks like.
Let me know if this is something you would like.

@jstarry
We would appreciate your feedbacks on:

  • Component page: you were expecting something a bit more "rich" than the 1st proposal. Does it fit? ... or it's too complex

  • Properties
    In the example I add props field to the struct and props comparison in the change method. That complexify a bit.
    Do you prefer that I move this code only in the

Optimizing rendering in the change method

BIG thanks to you Teymour!

@teymour-aldridge
Copy link
Contributor

teymour-aldridge commented May 10, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants