Use Default trait instead of new() in npm_and_rest example.

yewstack · Jun 20, 2020 · fceef03 · fceef03
1 parent 964d516
commit fceef03
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/examples/npm_and_rest/src/ccxt.rs b/examples/npm_and_rest/src/ccxt.rs
@@ -11,12 +11,14 @@ extern "C" {
     static ccxt: JsValue;
 }
 
-impl CcxtService {
-    pub fn default() -> Self {
+impl Default for CcxtService {
+    fn default() -> CcxtService {
         let lib: &JsValue = &ccxt;
         CcxtService(Some(lib))
     }
+}
 
+impl CcxtService {
     pub fn exchanges(&mut self) -> Vec<String> {
         let lib = self.0.as_ref().expect("ccxt library object lost");
         let v = {

diff --git a/examples/npm_and_rest/src/gravatar.rs b/examples/npm_and_rest/src/gravatar.rs
@@ -23,10 +23,6 @@ pub struct Entry {
 pub struct GravatarService {}
 
 impl GravatarService {
-    pub fn new() -> Self {
-        Self {}
-    }
-
     pub fn profile(&mut self, hash: &str, callback: Callback<Result<Profile, Error>>) -> FetchTask {
         let url = format!("https://en.gravatar.com/{}.json", hash);
         let handler = move |response: Response<Json<Result<Profile, Error>>>| {

diff --git a/examples/npm_and_rest/src/lib.rs b/examples/npm_and_rest/src/lib.rs
@@ -34,7 +34,7 @@ impl Component for Model {
     fn create(_: Self::Properties, link: ComponentLink<Self>) -> Self {
         Model {
             link: link.clone(),
-            gravatar: GravatarService::new(),
+            gravatar: GravatarService::default(),
             ccxt: CcxtService::default(),
             callback: link.callback(Msg::GravatarReady),
             profile: None,