Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVG Support #143

Closed
Boscop opened this issue Feb 11, 2018 · 8 comments · Fixed by #550
Closed

Add SVG Support #143

Boscop opened this issue Feb 11, 2018 · 8 comments · Fixed by #550

Comments

@Boscop
Copy link

Boscop commented Feb 11, 2018

Does yew support SVG dom nodes, or canvas drawing?
@karuna
Copy link

karuna commented Feb 14, 2018

It's already tracked here: #78

@Boscop
Copy link
Author

Boscop commented Feb 14, 2018

Ok, but what about svg?

@vitiral
Copy link
Contributor

vitiral commented Mar 27, 2018

@Boscop can you edit the title to "Add SVG Support" since canvas is covered by #78?

@Boscop Boscop changed the title SVG / Canvas support Add SVG Support Mar 28, 2018
@vitiral
Copy link
Contributor

vitiral commented Apr 8, 2018

We are probably going to need koute/stdweb#196 for this to happen.

That issue looks like it will be quite difficult to complete.

@vitiral vitiral mentioned this issue Apr 9, 2018
Closed
@Pauan
Copy link

Pauan commented Apr 9, 2018

This doesn't actually require stdweb support, as long as yew is okay with using raw js! blocks internally to construct the SVG nodes.

@vitiral
Copy link
Contributor

vitiral commented Apr 9, 2018 •
edited
Loading

Yes, see #194. That will be sufficient for at least basic support (at least I think it should be).

@vitiral
Copy link
Contributor

vitiral commented Apr 11, 2018

This can be closed, #203 supports this.

More "full featured" SVG support will have to wait until koute/stdweb#196

@Kwarrtz
Copy link

Kwarrtz commented Jun 8, 2018

Since koute/stdweb#196 has now been closed without implementation, what is the status of this issue?

@siler siler mentioned this issue Aug 31, 2018
Closed
@malleusinferni malleusinferni mentioned this issue Dec 12, 2018
Closed
@jstarry jstarry mentioned this issue Aug 3, 2019
Merged
bors bot added a commit that referenced this issue Aug 3, 2019
@bors @jstarry
Merge #550
a190a94 
550: Add support for svg by creating elements with correct namespace r=jstarry a=jstarry

Fixes #143
Fixes #328

Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
@bors bors bot closed this as completed in #550 Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for svg by creating elements with correct namespace jstarry/yew
5 participants
@Pauan @karuna @Boscop @vitiral @Kwarrtz