-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uses of anyhow
with error types
#925
Comments
Thanks @jplatte, it'd be great to do this before the next release since we're already making breaking changes for the error return types. Would you be willing to tackle this? |
Sure! :) |
Well... Despite the few locations in the code that use anyhow, an error type that could be used in its place would require to be convertible from multiple (de)serialization libraries error types AFAICT. I'm afraid I don't understand that part of yew well enough to implement this change. |
@jplatte ah yeah that's tricky. I think we will need to rework the format macros a bit. We could add an error variant to |
Sure.. Is there a general overview of the whole format things somewhere? That would help put things in perspective. |
Also, regarding |
I'm not a big fan of it, but it's used for GET requests currently. See here:
There isn't. Here's an issue: yewstack/docs#24 |
@jstarry Is there any update on this? I'd be willing to work on it. |
I've read in another issue that the whole format API is just going to be removed, so I think this is being worked on already basically. |
It has already been removed on master |
Looks like there is only a single use of |
As can be seen in #863, there's not a lot of code that uses
anyhow
'sanyhow!
orbail!
, and no code at all using itsContext
trait. Replacing those parts with more explicit error types would make it easier to handle the error cases, while dropping a dependency with a non-trivial amount of runtime magic and hardly complicating the code at all.The text was updated successfully, but these errors were encountered: