Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Tracking issue for v0.19.0 release 🎉 #2052

Closed
18 tasks done
mc1098 opened this issue Sep 13, 2021 · 17 comments
Closed
18 tasks done

🎉 Tracking issue for v0.19.0 release 🎉 #2052

mc1098 opened this issue Sep 13, 2021 · 17 comments

Comments

@mc1098
Copy link
Contributor

mc1098 commented Sep 13, 2021

This is a tracking issue for the upcoming v0.19.0 release 🎉

There are a number of things that I think should be completed before release and some others that would be nice to see included but shouldn't prevent the release. None of this is set in stone and I welcome everyone to comment below whether you think something should be added or removed from either list!

Blocking (in no particular order):

Notable but not blocking (in no particular order):

Issues that can be closed by new release

Two of these issues are about services that are going to be removed, so can't be fixed, and one is a more general
critique of the router which has been re-written.

Misc

Some extra bits to do before the release:

Expect all sections to change - I will update it as we go :)

@ranile
Copy link
Member

ranile commented Sep 15, 2021

Can we pin this issue?

@siku2
Copy link
Member

siku2 commented Sep 15, 2021

Can we pin this issue?

Oh, could've sworn I had already pressed the button 😅

@siku2 siku2 pinned this issue Sep 15, 2021
@mc1098
Copy link
Contributor Author

mc1098 commented Sep 15, 2021

Should we also add an example that uses function components to the list?

I wonder whether it's useful to base this off an existing example so that users can compare the two
approaches side by side.

Edit: this has been added in blocking issue list as an example for function components had been mention by #1129

@voidpumpkin
Copy link
Member

@mc1098 Could we add #2118 to this list as well? Getting current route will be impossible otherwise in yew@0.19.
(It solves bug #2116 )

@voidpumpkin
Copy link
Member

#2125 Is a nice feature and just missing documentation. Would be nice to have it for yew 0.19, so will add it to the list. Let me know if this is not ok.

@ranile
Copy link
Member

ranile commented Nov 11, 2021

#2125 Is a nice feature and just missing documentation. Would be nice to have it for yew 0.19, so will add it to the list. Let me know if this is not ok.

Even if we can't release it alongside 0.19, we could always release yew-agent 0.2. Agents are a separate crate now

@voidpumpkin
Copy link
Member

@hamza1311 oh that's right, thx
No reason to keep it in this list then

@voidpumpkin
Copy link
Member

I moved still open issues to 0.19 milestone, so I think this can be closed.

@voidpumpkin
Copy link
Member

Also leaving a comment here:
Moderators are working on setting up some automation for releases and 0.19 release is being held hostage because of that.

@ranile
Copy link
Member

ranile commented Nov 24, 2021

Re-opening this. The can be closed when 0.19 is released.

@ranile ranile reopened this Nov 24, 2021
@mibes
Copy link
Contributor

mibes commented Nov 30, 2021

Does it make sense to reconsider this statement in the README as part of the 0.19 release?

Note: Yew is not (yet) production ready but is great for side projects and internal tools.

For example:

Note: Yew is not 1.0 yet, so expect API changes.

Having used the master branch now for a while, I wonder if yew v0.19 is truly not ready for production use, keeping the above caveat in mind.

@voidpumpkin
Copy link
Member

Does it make sense to reconsider this statement in the README as part of the 0.19 release?

Note: Yew is not (yet) production ready but is great for side projects and internal tools.

For example:

Note: Yew is not 1.0 yet, so expect API changes.

Having used the master branch now for a while, I wonder if yew v0.19 is truly not ready for production use, keeping the above caveat in mind.

I would not reccomend yew in production, the api might change too mutch, to the point where you will be refactoring your app more than writing features.
I do agree that we are getting a lot closer to 1.0 and maybe even the next after 0.19 release might be the one.
But until then I believe the statement in the README is valid

@jbg
Copy link
Contributor

jbg commented Nov 30, 2021

The scary words "Yew is not (yet) production ready" make me think more of random crashes than API breakage. If you just mean that you don't promise API stability, then say that you don't promise API stability.

@mibes
Copy link
Contributor

mibes commented Nov 30, 2021

I agree with both your positions. I can see that you don't want people to be disappointed or frustrated by having to do major refactoring on API changes. However if you are open and transparent about this, it would be the user's decision if they want to take that work on, or not.

As @jbg pointed out, the current statement, does not do justice to all the work that went into yew up to this point and the level of quality it is currently at.

So maybe make the statement even more explicit:

Note: Yew is not 1.0 yet. Be prepared to do major refactoring due to breaking API changes.

@voidpumpkin
Copy link
Member

I agree with both your positions. I can see that you don't want people to be disappointed or frustrated by having to do major refactoring on API changes. However if you are open and transparent about this, it would be the user's decision if they want to take that work on, or not.

As @jbg pointed out, the current statement, does not do justice to all the work that went into yew up to this point and the level of quality it is currently at.

So maybe make the statement even more explicit:

Note: Yew is not 1.0 yet. Be prepared to do major refactoring due to breaking API changes.

Could you make a PR?

@mibes
Copy link
Contributor

mibes commented Nov 30, 2021

Sure.

@mc1098
Copy link
Contributor Author

mc1098 commented Dec 12, 2021

Yew v0.19.3 has been released 🎉 so I'm going to close this now 🥳

@mc1098 mc1098 closed this as completed Dec 12, 2021
@ranile ranile unpinned this issue Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants