Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of the router #1852

Closed
1 of 6 tasks
Tracked by #2052
ranile opened this issue May 17, 2021 · 4 comments · Fixed by #2166
Closed
1 of 6 tasks
Tracked by #2052

Improve documentation of the router #1852

ranile opened this issue May 17, 2021 · 4 comments · Fixed by #2166

Comments

@ranile
Copy link
Member

ranile commented May 17, 2021

This is about:
Undocumented code

Documentation to be added

  • How to specify route parameters, describing the syntax and the possibilities, maybe link to the route_recognizer
  • Examples for parsing and pushing query parameters
  • Document how to listen to route changes

Originally posted by @siku2 here: #1791 (comment)

Questionaire (Optional)

  • I'd like to write this documentation
  • I'd like to write this documentation but I'm not sure what's needed
  • I don't have time to add this right now, but maybe later
@voidpumpkin
Copy link
Member

voidpumpkin commented Nov 11, 2021

@hamza1311 Could you convert the points into a checkbox list?
I think the only bit I cant find yet documented is about the RouteListener dropping, first 2 points are already documented

@mc1098
Copy link
Contributor

mc1098 commented Nov 11, 2021

Could you convert the points into a checkbox list?

@voidpumpkin You have the power to edit issues now that you have joined the dark side of the force (maintainers) 👀

Also as just a quick impression from skimming the Router docs is that it seems function component based so, I think it would be difficult for someone not using function components to workout the alternative. I think this problem will pop up more and more in general so, might be worth looking into using Tabs in Docusaurus to provide both function component and struct component information :).

@ranile
Copy link
Member Author

ranile commented Nov 11, 2021

Using function components also means that the docs show type instead of struct for the components.

Also @voidpumpkin, feel free to update the issue as you see fit. I haven't looked at the new new router yet so I can't say what needs to be documented

@ranile
Copy link
Member Author

ranile commented Nov 11, 2021

Update: last 2 points are still undocumented, first one could have some polish. I'll update the issue with checkboxes

@ranile ranile added this to the v0.19 milestone Nov 21, 2021
@ranile ranile removed this from the Upcoming release milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants